diff --git a/src/plugins/qmakeprojectmanager/qmakekitinformation.cpp b/src/plugins/qmakeprojectmanager/qmakekitinformation.cpp index 57550e2e52f..79293fd914d 100644 --- a/src/plugins/qmakeprojectmanager/qmakekitinformation.cpp +++ b/src/plugins/qmakeprojectmanager/qmakekitinformation.cpp @@ -26,6 +26,7 @@ #include "qmakekitinformation.h" #include "qmakekitconfigwidget.h" +#include "qmakeprojectmanagerconstants.h" #include #include @@ -61,10 +62,10 @@ QList QmakeKitInformation::validate(const Kit *k) const FileName mkspec = QmakeKitInformation::mkspec(k); if (!version && !mkspec.isEmpty()) result << Task(Task::Warning, tr("No Qt version set, so mkspec is ignored."), - FileName(), -1, Constants::TASK_CATEGORY_BUILDSYSTEM); + FileName(), -1, ProjectExplorer::Constants::TASK_CATEGORY_BUILDSYSTEM); if (version && !version->hasMkspec(mkspec)) result << Task(Task::Error, tr("Mkspec not found for Qt version."), - FileName(), -1, Constants::TASK_CATEGORY_BUILDSYSTEM); + FileName(), -1, ProjectExplorer::Constants::TASK_CATEGORY_BUILDSYSTEM); return result; } @@ -82,13 +83,13 @@ void QmakeKitInformation::setup(Kit *k) if (spec.isEmpty()) spec = version->mkspec(); - ToolChain *tc = ToolChainKitInformation::toolChain(k, Constants::CXX_LANGUAGE_ID); + ToolChain *tc = ToolChainKitInformation::toolChain(k, ProjectExplorer::Constants::CXX_LANGUAGE_ID); if (!tc || (!tc->suggestedMkspecList().empty() && !tc->suggestedMkspecList().contains(spec))) { const QList possibleTcs = ToolChainManager::toolChains( [version](const ToolChain *t) { return t->isValid() - && t->language() == Core::Id(Constants::CXX_LANGUAGE_ID) + && t->language() == Core::Id(ProjectExplorer::Constants::CXX_LANGUAGE_ID) && version->qtAbis().contains(t->targetAbi()); }); if (!possibleTcs.isEmpty()) { @@ -121,7 +122,7 @@ void QmakeKitInformation::addToMacroExpander(Kit *kit, MacroExpander *expander) Core::Id QmakeKitInformation::id() { - return "QtPM4.mkSpecInformation"; + return Constants::KIT_INFORMATION_ID; } FileName QmakeKitInformation::mkspec(const Kit *k) @@ -152,7 +153,8 @@ FileName QmakeKitInformation::defaultMkspec(const Kit *k) if (!version) // No version, so no qmake return FileName(); - return version->mkspecFor(ToolChainKitInformation::toolChain(k, Constants::CXX_LANGUAGE_ID)); + return version->mkspecFor(ToolChainKitInformation::toolChain(k, + ProjectExplorer::Constants::CXX_LANGUAGE_ID)); } } // namespace QmakeProjectManager diff --git a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerconstants.h b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerconstants.h index 71b2bd7a7a6..8c3ed2a8600 100644 --- a/src/plugins/qmakeprojectmanager/qmakeprojectmanagerconstants.h +++ b/src/plugins/qmakeprojectmanager/qmakeprojectmanagerconstants.h @@ -67,5 +67,8 @@ const char QMAKE_BC_ID[] = "Qt4ProjectManager.Qt4BuildConfiguration"; // ICONS const char ICON_QTQUICK_APP[] = ":/wizards/images/qtquickapp.png"; +// Kit +const char KIT_INFORMATION_ID[] = "QtPM4.mkSpecInformation"; + } // namespace Constants } // namespace QmakeProjectManager diff --git a/src/plugins/qnx/qnx.qbs b/src/plugins/qnx/qnx.qbs index d3b29d7ef41..b17a538411c 100644 --- a/src/plugins/qnx/qnx.qbs +++ b/src/plugins/qnx/qnx.qbs @@ -12,7 +12,6 @@ QtcPlugin { Depends { name: "Debugger" } Depends { name: "ProjectExplorer" } Depends { name: "QtSupport" } - Depends { name: "QmakeProjectManager" } Depends { name: "RemoteLinux" } files: [ diff --git a/src/plugins/qnx/qnx_dependencies.pri b/src/plugins/qnx/qnx_dependencies.pri index fd104bd9f08..fc905aacd16 100644 --- a/src/plugins/qnx/qnx_dependencies.pri +++ b/src/plugins/qnx/qnx_dependencies.pri @@ -8,6 +8,5 @@ QTC_PLUGIN_DEPENDS += \ coreplugin \ debugger \ projectexplorer \ - qmakeprojectmanager \ qtsupport \ remotelinux diff --git a/src/plugins/qnx/qnxconfiguration.cpp b/src/plugins/qnx/qnxconfiguration.cpp index 282e5980854..0f15f9fcfe3 100644 --- a/src/plugins/qnx/qnxconfiguration.cpp +++ b/src/plugins/qnx/qnxconfiguration.cpp @@ -41,7 +41,7 @@ #include #include -#include +#include #include #include @@ -329,7 +329,7 @@ ProjectExplorer::Kit *QnxConfiguration::createKit( kit->setSticky(DeviceTypeKitInformation::id(), true); kit->setSticky(SysRootKitInformation::id(), true); kit->setSticky(DebuggerKitInformation::id(), true); - kit->setSticky(QmakeProjectManager::QmakeKitInformation::id(), true); + kit->setSticky(QmakeProjectManager::Constants::KIT_INFORMATION_ID, true); // add kit with device and qt version not sticky KitManager::registerKit(kit); diff --git a/src/plugins/qnx/qnxrunconfiguration.cpp b/src/plugins/qnx/qnxrunconfiguration.cpp index 1a2559ecd30..81daeb3f959 100644 --- a/src/plugins/qnx/qnxrunconfiguration.cpp +++ b/src/plugins/qnx/qnxrunconfiguration.cpp @@ -29,9 +29,6 @@ #include #include -#include -#include - #include #include diff --git a/src/plugins/qnx/qnxrunconfigurationfactory.cpp b/src/plugins/qnx/qnxrunconfigurationfactory.cpp index d2045680855..05f9abfe8eb 100644 --- a/src/plugins/qnx/qnxrunconfigurationfactory.cpp +++ b/src/plugins/qnx/qnxrunconfigurationfactory.cpp @@ -31,7 +31,8 @@ #include #include -#include + +#include using namespace ProjectExplorer; @@ -47,18 +48,11 @@ QnxRunConfigurationFactory::QnxRunConfigurationFactory(QObject *parent) : QList QnxRunConfigurationFactory::availableCreators(Target *parent, IRunConfigurationFactory::CreationMode mode) const { - auto project = qobject_cast(parent->project()); - return Utils::transform(project->buildTargets(mode), [this](const BuildTargetInfo &bti) { - return convert(tr("%1 on QNX Device").arg(QFileInfo(bti.targetName).completeBaseName())); + Q_UNUSED(mode); + return Utils::transform(parent->applicationTargets().list, [this](const BuildTargetInfo &bti) { + return convert(tr("%1 on QNX Device").arg(QFileInfo(bti.targetName).completeBaseName()), bti.targetName); }); } -bool QnxRunConfigurationFactory::canCreateHelper(ProjectExplorer::Target *parent, - const QString &buildTarget) const -{ - auto project = qobject_cast(parent->project()); - return project->hasApplicationProFile(Utils::FileName::fromString(buildTarget)); -} - } // namespace Internal } // namespace Qnx diff --git a/src/plugins/qnx/qnxrunconfigurationfactory.h b/src/plugins/qnx/qnxrunconfigurationfactory.h index 0692602448b..4558ab3d9f4 100644 --- a/src/plugins/qnx/qnxrunconfigurationfactory.h +++ b/src/plugins/qnx/qnxrunconfigurationfactory.h @@ -40,8 +40,6 @@ public: QList availableCreators(ProjectExplorer::Target *parent, CreationMode mode = UserCreate) const override; - - bool canCreateHelper(ProjectExplorer::Target *parent, const QString &suffix) const override; }; } // namespace Internal