feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

fix m_invertNext effect scoping

Browse Source 
an evaluation function can be an include statement. the included code
must neither inherit nor change the current inversion state.
This commit is contained in:
Oswald Buddenhagen
2009-05-14 14:30:08 +02:00
parent 51f5ee959f
commit 68b1b828e6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared/proparser/profileevaluator.cpp
View File

@@ -869,6 +869,9 @@ bool ProFileEvaluator::Private::visitProValue(ProValue *value)
bool ProFileEvaluator::Private::visitProFunction(ProFunction *func) bool ProFileEvaluator::Private::visitProFunction(ProFunction *func)
{ {
// Make sure that called subblocks don't inherit & destroy the state
bool invertThis = m_invertNext;
m_invertNext = false;
if (!m_sts.updateCondition || m_sts.condition == ConditionFalse) { if (!m_sts.updateCondition || m_sts.condition == ConditionFalse) {
QString text = func->text(); QString text = func->text();
int lparen = text.indexOf(QLatin1Char('(')); int lparen = text.indexOf(QLatin1Char('('));
@@ -878,10 +881,9 @@ bool ProFileEvaluator::Private::visitProFunction(ProFunction *func)
QString funcName = text.left(lparen); QString funcName = text.left(lparen);
m_lineNo = func->lineNumber(); m_lineNo = func->lineNumber();
bool result = evaluateConditionalFunction(funcName.trimmed(), arguments); bool result = evaluateConditionalFunction(funcName.trimmed(), arguments);
if (!m_skipLevel && (result ^ m_invertNext)) if (!m_skipLevel && (result ^ invertThis))
m_sts.condition = ConditionTrue; m_sts.condition = ConditionTrue;
} }
m_invertNext = false;
return true; return true;
} }