feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: avoid endless loop created by dumpers that crash before outputting

Browse Source 
the child list.
This commit is contained in:
hjk
2009-08-20 13:51:05 +02:00
parent a43bda6035
commit 698b5ff253
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -2902,6 +2902,18 @@ void GdbEngine::runDebuggingHelper(const WatchData &data0, bool dumpChildren)
} }
WatchData data = data0; WatchData data = data0;
// Avoid endless loops created by faulty dumpers
if (m_processedNames.contains(data.iname)) {
emit gdbInputAvailable(LogStatus,
_("<Breaking endless loop for %1>").arg(data.iname));
data.setAllUnneeded();
data.setValue(_("<unavailable>"));
data.setHasChildren(false);
insertData(data);
return;
}
m_processedNames.insert(data.iname);
QByteArray params; QByteArray params;
QStringList extraArgs; QStringList extraArgs;
const QtDumperHelper::TypeData td = m_dumperHelper.typeData(data0.type); const QtDumperHelper::TypeData td = m_dumperHelper.typeData(data0.type);
@@ -3531,6 +3543,7 @@ void GdbEngine::updateLocals()
tryQueryDebuggingHelpers(); tryQueryDebuggingHelpers();
m_pendingRequests = 0; m_pendingRequests = 0;
m_processedNames.clear();
PENDING_DEBUG("\nRESET PENDING"); PENDING_DEBUG("\nRESET PENDING");
//m_toolTipCache.clear(); //m_toolTipCache.clear();

1
src/plugins/debugger/gdb/gdbengine.h
View File

@@ -374,6 +374,7 @@ private:
QString parseDisassembler(const GdbMi &lines); QString parseDisassembler(const GdbMi &lines);
int m_pendingRequests; int m_pendingRequests;
QSet<QString> m_processedNames;
QtDumperHelper m_dumperHelper; QtDumperHelper m_dumperHelper;