feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

remove the entirely insane whitespace compression

Browse Source 
it was merely an artifact of using QString::simplified() on the
unparsed (!) project code. there is no reason why anyone should actually
rely on it, so just remove it.

Change-Id: If9b957c4b1263f3990a2331f8851bb1c06154ea8
Reviewed-by: Qt Doc Bot <qt_docbot@qt-project.org>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
(cherry picked from qtbase/c3c4f1eb5301a4fda17a9a48012df45f9a0ee7a3)
This commit is contained in:
Oswald Buddenhagen
2012-09-03 17:05:33 +02:00
committed by Oswald Buddenhagen
parent b154c3255b
commit 6a0a13f601
1 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/shared/proparser/qmakeparser.cpp
View File

@@ -334,9 +334,8 @@ bool QMakeParser::read(ProFile *pro, const QString &in, int line, SubGrammar gra
int argc = 0;
int wordCount = 0; // Number of words in currently accumulated expression
int lastIndent = 0; // Previous line's indentation, to detect accidental continuation abuse
bool putSpace = false; // Only ever true inside quoted string
bool lineMarked = true; // For in-expression markers
ushort needSep = TokNewStr; // Complementary to putSpace: separator outside quotes
ushort needSep = TokNewStr; // Met unquoted whitespace
ushort quote = 0;
ushort term = 0;
@@ -488,10 +487,6 @@ bool QMakeParser::read(ProFile *pro, const QString &in, int line, SubGrammar gra
if (c == '$') {
if (*cur == '$') { // may be EOF, EOL, WS, '#' or '\\' if past end
cur++;
if (putSpace) {
putSpace = false;
*ptr++ = ' ';
}
FLUSH_LITERAL();
if (!lineMarked) {
lineMarked = true;
@@ -613,13 +608,6 @@ bool QMakeParser::read(ProFile *pro, const QString &in, int line, SubGrammar gra
} else if (quote) {
if (c == quote) {
quote = 0;
if (putSpace) {
putSpace = false;
*ptr++ = ' ';
}
goto nextChr;
} else if ((c == ' ' || c == '\t') && context != CtxPureValue) {
putSpace = true;
goto nextChr;
} else if (c == '!' && ptr == xprPtr && context == CtxTest) {
m_invert ^= true;
@@ -787,10 +775,6 @@ bool QMakeParser::read(ProFile *pro, const QString &in, int line, SubGrammar gra
languageWarning(fL1S("Possible accidental line continuation"));
}
}
if (putSpace) {
putSpace = false;
*ptr++ = ' ';
}
*ptr++ = c;
nextChr:
if (cur == end)
@@ -801,7 +785,7 @@ bool QMakeParser::read(ProFile *pro, const QString &in, int line, SubGrammar gra
lineEnd:
if (lineCont) {
if (quote) {
putSpace = true;
*ptr++ = ' ';
} else {
FLUSH_LITERAL();
needSep = TokNewStr;