feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Provide empty implementation for ILocatorFilter::refresh()

Browse Source 
Make this method just virtual, not a pure virtual.
Remove all empty reimplementations of this method.

Change-Id: Idf10e492355e8519172facd421ea0b2b13ce3b80
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2021-02-11 11:41:55 +01:00
parent 9ad5cd5f58
commit 6a2088d8ec
34 changed files with 3 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cpptools/cppcurrentdocumentfilter.cpp
View File

@@ -127,11 +127,6 @@ void CppCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection,
Core::EditorManager::openEditorAt(info->fileName(), info->line(), info->column());
}
void CppCurrentDocumentFilter::refresh(QFutureInterface<void> &future)
{
Q_UNUSED(future)
}
void CppCurrentDocumentFilter::onDocumentUpdated(Document::Ptr doc)
{
QMutexLocker locker(&m_mutex);

1
src/plugins/cpptools/cppcurrentdocumentfilter.h
View File

@@ -49,7 +49,6 @@ public:
const QString &entry) override;
void accept(Core::LocatorFilterEntry selection,
QString *newText, int *selectionStart, int *selectionLength) const override;
void refresh(QFutureInterface<void> &future) override;
private:
void onDocumentUpdated(CPlusPlus::Document::Ptr doc);

5
src/plugins/cpptools/cpplocatorfilter.cpp
View File

@@ -61,11 +61,6 @@ Core::LocatorFilterEntry CppLocatorFilter::filterEntryFromIndexItem(IndexItem::P
return filterEntry;
}
void CppLocatorFilter::refresh(QFutureInterface<void> &future)
{
Q_UNUSED(future)
}
QList<Core::LocatorFilterEntry> CppLocatorFilter::matchesFor(
QFutureInterface<Core::LocatorFilterEntry> &future, const QString &entry)
{

1
src/plugins/cpptools/cpplocatorfilter.h
View File

@@ -45,7 +45,6 @@ public:
const QString &entry) override;
void accept(Core::LocatorFilterEntry selection,
QString *newText, int *selectionStart, int *selectionLength) const override;
void refresh(QFutureInterface<void> &future) override;
protected:
virtual IndexItem::ItemType matchTypes() const { return IndexItem::All; }