feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qbs: Avoid popping up general messages pane

Browse Source 
Except on direct user action. Use more evocative message manager API.

Task-number: QTCREATORBUG-24430
Change-Id: I44c6088904b2018baccb72cd3651e2ab62dc1358
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Eike Ziller
2020-12-16 14:59:25 +01:00
parent 265ee14c89
commit 6a2a07d516
4 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qbsprojectmanager/qbssession.cpp
View File

@@ -491,8 +491,7 @@ void QbsSession::handlePacket(const QJsonObject &packet)
} else if (type == "install-done") {
emit projectInstalled(getErrorInfo(packet));
} else if (type == "log-data") {
Core::MessageManager::write("[qbs] " + packet.value("message").toString(),
Core::MessageManager::Silent);
Core::MessageManager::writeSilently("[qbs] " + packet.value("message").toString());
} else if (type == "warning") {
const ErrorInfo errorInfo = ErrorInfo(packet.value("warning").toObject());
@@ -618,11 +617,10 @@ void QbsSession::handleFileListUpdated(const QJsonObject &reply)
setProjectDataFromReply(reply, false);
const QStringList failedFiles = arrayToStringList(reply.value("failed-files"));
if (!failedFiles.isEmpty()) {
Core::MessageManager::write(tr("Failed to update files in Qbs project: %1.\n"
"The affected files are: \n\t%2")
.arg(getErrorInfo(reply).toString(),
failedFiles.join("\n\t")),
Core::MessageManager::ModeSwitch);
Core::MessageManager::writeFlashing(
tr("Failed to update files in Qbs project: %1.\n"
"The affected files are: \n\t%2")
.arg(getErrorInfo(reply).toString(), failedFiles.join("\n\t")));
}
emit fileListUpdated();
}