feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Avoid some Gdb* in common type names

Browse Source 
They had been created for use with GDB, but are more general
nowadays.

s/GdbResponse/DebuggerResponse/,
s/GdbResultClass/ResultClass, etc

Change-Id: Idfa3e280cdda882a8b3f02dff7e7d993e7e82d03
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
hjk
2015-02-05 15:47:07 +01:00
parent 2813643cfe
commit 6a2d6b6d20
14 changed files with 262 additions and 275 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/debugger/gdb/gdbplainengine.cpp
View File

@@ -45,9 +45,7 @@
namespace Debugger {
namespace Internal {
#define CB(callback) \
static_cast<GdbEngine::GdbCommandCallback>(&GdbPlainEngine::callback), \
STRINGIFY(callback)
#define CB(callback) [this](const DebuggerResponse &r) { callback(r); }, STRINGIFY(callback)
GdbPlainEngine::GdbPlainEngine(const DebuggerStartParameters &startParameters)
: GdbEngine(startParameters)
@@ -57,7 +55,6 @@ GdbPlainEngine::GdbPlainEngine(const DebuggerStartParameters &startParameters)
this, SLOT(readDebugeeOutput(QByteArray)));
}
void GdbPlainEngine::setupInferior()
{
QTC_ASSERT(state() == InferiorSetupRequested, qDebug() << state());
@@ -69,10 +66,10 @@ void GdbPlainEngine::setupInferior()
CB(handleFileExecAndSymbols));
}
void GdbPlainEngine::handleFileExecAndSymbols(const GdbResponse &response)
void GdbPlainEngine::handleFileExecAndSymbols(const DebuggerResponse &response)
{
QTC_ASSERT(state() == InferiorSetupRequested, qDebug() << state());
if (response.resultClass == GdbResultDone) {
if (response.resultClass == ResultDone) {
handleInferiorPrepared();
} else {
QByteArray ba = response.data["msg"].data();
@@ -92,10 +89,10 @@ void GdbPlainEngine::runEngine()
postCommand("-exec-run", GdbEngine::RunRequest, CB(handleExecRun));
}
void GdbPlainEngine::handleExecRun(const GdbResponse &response)
void GdbPlainEngine::handleExecRun(const DebuggerResponse &response)
{
QTC_ASSERT(state() == EngineRunRequested, qDebug() << state());
if (response.resultClass == GdbResultRunning) {
if (response.resultClass == ResultRunning) {
//notifyEngineRunOkAndInferiorRunRequested();
notifyEngineRunAndInferiorRunOk(); // For gdb < 7.0
//showStatusMessage(tr("Running..."));