feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

StudioWelcome: Fix QTC_ASSERT

Browse Source 
Deleting QtcProcess instance directly from
one of its signal handlers will lead to crash!

I cannot confirm this crash actually happened, but we should play save
and delete the archive from the event loop.

Change-Id: Ie27291c9ac8b300478ed8396d25a76b343f238be
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Thomas Hartmann
2022-08-23 12:25:55 +02:00
parent 4bfdf9fc46
commit 6a3933c87a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/studiowelcome/examplecheckout.cpp
View File

@@ -424,7 +424,7 @@ void FileExtractor::extract()
}); });
QObject::connect(archive, &Utils::Archive::finished, this, [this, archive](bool ret) { QObject::connect(archive, &Utils::Archive::finished, this, [this, archive](bool ret) {
delete archive; archive->deleteLater();
m_finished = ret; m_finished = ret;
m_timer.stop(); m_timer.stop();