From 6a5340175bc7d908987d17d4022bba434a462cc8 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Wed, 22 Sep 2021 13:11:37 +0200 Subject: [PATCH] CMakePM: Improve cmake default generator setup Docker images with UNIX on a Windows host should get a proper default generator. This allows to build projects with a default set up kit for docker out of the box without modifying the kit values or the project setup. Change-Id: Ic32e72c28d98a367e71f19d4e1c211ec7a4e613e Reviewed-by: Cristian Adam --- src/plugins/cmakeprojectmanager/cmakekitinformation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp b/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp index c5abf4d8561..ef051d4a523 100644 --- a/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp +++ b/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp @@ -685,7 +685,7 @@ QVariant CMakeGeneratorKitAspect::defaultValue(const Kit *k) const return GeneratorInfo("Ninja").toVariant(); } - if (HostOsInfo::isWindowsHost()) { + if (tool->filePath().osType() == OsTypeWindows) { // *sigh* Windows with its zoo of incompatible stuff again... ToolChain *tc = ToolChainKitAspect::cxxToolChain(k); if (tc && tc->typeId() == ProjectExplorer::Constants::MINGW_TOOLCHAIN_TYPEID) {