feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use a functor for BuildSystem creation

Browse Source 
... instead of creating the BuildSystem direct. This will help the
shift of BuildSystem owner ship as a Project will have potentially
multiple BuildSystem instances (one per BuildConfiguration), but
still be responsible for creating them with the Targets.

Change-Id: I2dd71c7687ed41af9e42c874b3f932ce704e7ee3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2019-10-23 08:47:05 +02:00
parent 5b815d22a3
commit 6a878c7293
16 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/project.cpp
View File

@@ -888,10 +888,9 @@ Utils::Environment Project::activeParseEnvironment() const
return result;
}
void Project::setBuildSystem(std::unique_ptr<BuildSystem> &&bs)
void Project::setBuildSystemCreator(const std::function<BuildSystem *(Project *)> &creator)
{
QTC_ASSERT(!bs->parent(), bs->setParent(nullptr));
d->m_buildSystem = std::move(bs);
d->m_buildSystem.reset(creator(this));
}
Core::Context Project::projectContext() const