diff --git a/src/plugins/qnx/blackberryconfiguration.cpp b/src/plugins/qnx/blackberryconfiguration.cpp index eceaee1916d..ad30e0f88da 100644 --- a/src/plugins/qnx/blackberryconfiguration.cpp +++ b/src/plugins/qnx/blackberryconfiguration.cpp @@ -56,7 +56,6 @@ #include #include #include -#include namespace Qnx { namespace Internal { @@ -449,46 +448,24 @@ Utils::FileName BlackBerryConfiguration::sysRoot() const return m_config.sysRoot; } -QString BlackBerryConfiguration::dataDirPath() const -{ - const QString homeDir = QDir::homePath(); - - if (Utils::HostOsInfo::isMacHost()) - return homeDir + QLatin1String("/Library/Research in Motion"); - - if (Utils::HostOsInfo::isAnyUnixHost()) - return homeDir + QLatin1String("/.rim"); - - if (Utils::HostOsInfo::isWindowsHost()) { - // Get the proper storage location on Windows using QDesktopServices, - // to not hardcode "AppData/Local", as it might refer to "AppData/Roaming". - QString dataDir = QDesktopServices::storageLocation(QDesktopServices::DataLocation); - dataDir = dataDir.left(dataDir.indexOf(QCoreApplication::organizationName())); - dataDir.append(QLatin1String("Research in Motion")); - return dataDir; - } - - return QString(); -} - QString BlackBerryConfiguration::barsignerCskPath() const { - return dataDirPath() + QLatin1String("/barsigner.csk"); + return QnxUtils::dataDirPath() + QLatin1String("/barsigner.csk"); } QString BlackBerryConfiguration::barsignerDbPath() const { - return dataDirPath() + QLatin1String("/barsigner.db"); + return QnxUtils::dataDirPath() + QLatin1String("/barsigner.db"); } QString BlackBerryConfiguration::defaultKeystorePath() const { - return dataDirPath() + QLatin1String("/author.p12"); + return QnxUtils::dataDirPath() + QLatin1String("/author.p12"); } QString BlackBerryConfiguration::defaultDebugTokenPath() const { - return dataDirPath() + QLatin1String("/debugtoken.bar"); + return QnxUtils::dataDirPath() + QLatin1String("/debugtoken.bar"); } // TODO: QnxUtils::parseEnvFile() and qnxEnv() to return Util::Enviroment instead(?) diff --git a/src/plugins/qnx/blackberryconfiguration.h b/src/plugins/qnx/blackberryconfiguration.h index aac961150a3..d538f610ef6 100644 --- a/src/plugins/qnx/blackberryconfiguration.h +++ b/src/plugins/qnx/blackberryconfiguration.h @@ -83,7 +83,6 @@ public: QString targetName() const; QString barsignerCskPath() const; QString barsignerDbPath() const; - QString dataDirPath() const; QString defaultKeystorePath() const; QString defaultDebugTokenPath() const; void loadSettings(); diff --git a/src/plugins/qnx/blackberrydeviceconfigurationwidget.cpp b/src/plugins/qnx/blackberrydeviceconfigurationwidget.cpp index 9ef090bd723..252cbb320ca 100644 --- a/src/plugins/qnx/blackberrydeviceconfigurationwidget.cpp +++ b/src/plugins/qnx/blackberrydeviceconfigurationwidget.cpp @@ -36,6 +36,7 @@ #include "blackberryconfiguration.h" #include "blackberrydeviceconnectionmanager.h" #include "qnxconstants.h" +#include "qnxutils.h" #include #include @@ -81,7 +82,7 @@ BlackBerryDeviceConfigurationWidget::BlackBerryDeviceConfigurationWidget(const I ui->debugToken->addButton(tr("Upload"), this, SLOT(uploadDebugToken())); uploadButton = ui->debugToken->buttonAtIndex(2); - QString debugTokenBrowsePath = BlackBerryConfiguration::instance().dataDirPath(); + QString debugTokenBrowsePath = QnxUtils::dataDirPath(); if (!QFileInfo(debugTokenBrowsePath).exists()) debugTokenBrowsePath = QDir::homePath(); ui->debugToken->setInitialBrowsePathBackup(debugTokenBrowsePath); diff --git a/src/plugins/qnx/blackberrydeviceconfigurationwizardpages.cpp b/src/plugins/qnx/blackberrydeviceconfigurationwizardpages.cpp index f923cc5cd07..aad9c0f6e82 100644 --- a/src/plugins/qnx/blackberrydeviceconfigurationwizardpages.cpp +++ b/src/plugins/qnx/blackberrydeviceconfigurationwizardpages.cpp @@ -36,6 +36,7 @@ #include "ui_blackberrydeviceconfigurationwizardsetuppage.h" #include "ui_blackberrydeviceconfigurationwizardsshkeypage.h" #include "blackberryconfiguration.h" +#include "qnxutils.h" #include #include @@ -70,7 +71,7 @@ BlackBerryDeviceConfigurationWizardSetupPage::BlackBerryDeviceConfigurationWizar m_ui->debugToken->setExpectedKind(Utils::PathChooser::File); m_ui->debugToken->setPromptDialogFilter(QLatin1String("*.bar")); - QString debugTokenBrowsePath = BlackBerryConfiguration::instance().dataDirPath(); + QString debugTokenBrowsePath = QnxUtils::dataDirPath(); if (!QFileInfo(debugTokenBrowsePath).exists()) debugTokenBrowsePath = QDir::homePath(); m_ui->debugToken->setInitialBrowsePathBackup(debugTokenBrowsePath); @@ -168,7 +169,7 @@ BlackBerryDeviceConfigurationWizardSshKeyPage::BlackBerryDeviceConfigurationWiza m_ui->privateKey->setExpectedKind(Utils::PathChooser::File); m_ui->progressBar->hide(); - QString initialBrowsePath = BlackBerryConfiguration::instance().dataDirPath(); + QString initialBrowsePath = QnxUtils::dataDirPath(); if (!QFileInfo(initialBrowsePath).exists()) initialBrowsePath = QDir::homePath(); m_ui->privateKey->setInitialBrowsePathBackup(initialBrowsePath); @@ -267,7 +268,7 @@ bool BlackBerryDeviceConfigurationWizardSshKeyPage::saveKeys(const QString &priv void BlackBerryDeviceConfigurationWizardSshKeyPage::generateSshKeys() { - QString lookInDir = BlackBerryConfiguration::instance().dataDirPath(); + QString lookInDir = QnxUtils::dataDirPath(); if (!QFileInfo(lookInDir).exists()) lookInDir = QDir::homePath(); diff --git a/src/plugins/qnx/qnxutils.cpp b/src/plugins/qnx/qnxutils.cpp index 791a558444f..f7a7104b6aa 100644 --- a/src/plugins/qnx/qnxutils.cpp +++ b/src/plugins/qnx/qnxutils.cpp @@ -35,6 +35,7 @@ #include #include +#include using namespace Qnx; using namespace Qnx::Internal; @@ -213,3 +214,26 @@ Utils::FileName QnxUtils::executableWithExtension(const Utils::FileName &fileNam result.append(QLatin1String(".exe")); return result; } + +QString QnxUtils::dataDirPath() +{ + const QString homeDir = QDir::homePath(); + + if (Utils::HostOsInfo::isMacHost()) + return homeDir + QLatin1String("/Library/Research in Motion"); + + if (Utils::HostOsInfo::isAnyUnixHost()) + return homeDir + QLatin1String("/.rim"); + + if (Utils::HostOsInfo::isWindowsHost()) { + // Get the proper storage location on Windows using QDesktopServices, + // to not hardcode "AppData/Local", as it might refer to "AppData/Roaming". + QString dataDir = QDesktopServices::storageLocation(QDesktopServices::DataLocation); + dataDir = dataDir.left(dataDir.indexOf(QCoreApplication::organizationName())); + dataDir.append(QLatin1String("Research in Motion")); + return dataDir; + } + + return QString(); +} + diff --git a/src/plugins/qnx/qnxutils.h b/src/plugins/qnx/qnxutils.h index 5b8b179b6aa..571a11f6441 100644 --- a/src/plugins/qnx/qnxutils.h +++ b/src/plugins/qnx/qnxutils.h @@ -57,6 +57,7 @@ public: static QString envFilePath(const QString & ndkPath); static void prependQnxMapToEnvironment(const QMultiMap &qnxMap, Utils::Environment &env); static Utils::FileName executableWithExtension(const Utils::FileName &fileName); + static QString dataDirPath(); }; } // namespace Internal