From 6b8e2fbd49a5982fac84f8747c3d14b72feb4f0a Mon Sep 17 00:00:00 2001
From: Thomas Hartmann <thomas.hartmann@qt.io>
Date: Fri, 16 Sep 2022 17:21:03 +0200
Subject: [PATCH] QmlDesigner: Show proper error dialog if adding duplicate
 property

Task-number: QDS-7702
Change-Id: I43f07afa95cef75e53bbc0259f6dd21b7c1a5363
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
---
 .../propertyeditor/dynamicpropertiesproxymodel.cpp         | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp b/src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp
index 3b45d7480f1..b5791ba2870 100644
--- a/src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp
+++ b/src/plugins/qmldesigner/components/propertyeditor/dynamicpropertiesproxymodel.cpp
@@ -35,6 +35,7 @@
 #include <qmldesignerconstants.h>
 #include <qmldesignerplugin.h>
 
+#include <coreplugin/messagebox.h>
 #include <utils/qtcassert.h>
 
 #include <QScopeGuard>
@@ -150,6 +151,12 @@ void DynamicPropertiesProxyModel::createProperty(const QString &name, const QStr
     if (selectedNodes.count() == 1) {
         const ModelNode modelNode = selectedNodes.constFirst();
         if (modelNode.isValid()) {
+            if (modelNode.hasProperty(name.toUtf8())) {
+                Core::AsynchronousMessageBox::warning(tr("Property already exists"),
+                                                      tr("Property '%1' already exists")
+                                                          .arg(name));
+                return;
+            }
             try {
                 if (Internal::DynamicPropertiesModel::isValueType(typeName)) {
                     QVariant value = Internal::DynamicPropertiesModel::defaultValueForType(typeName);