Beautifier: Avoid raw loops wherever applicable

Change-Id: I8b595ce0f7b3544466c6308457bf22826d1dafeb
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

src/plugins/beautifier/artisticstyle/artisticstyle.cpp

@@ -119,8 +119,7 @@ QString ArtisticStyle::configurationFile() const
         if (const ProjectExplorer::Project *project
                 = ProjectExplorer::ProjectTree::currentProject()) {
             const QStringList files = project->files(ProjectExplorer::Project::AllFiles);
-            for (int i = 0, total = files.size(); i < total; ++i) {
+            foreach (const QString &file, files) {
-                const QString &file = files.at(i);
                 if (!file.endsWith(QLatin1String(".astylerc")))
                     continue;
                 const QFileInfo fi(file);

src/plugins/beautifier/artisticstyle/artisticstylesettings.cpp

@@ -180,11 +180,10 @@ void ArtisticStyleSettings::createDocumentationFile() const
     // astyle writes its output to 'error'...
     const QStringList lines = QString::fromUtf8(process.readAllStandardError())
             .split(QLatin1Char('\n'));
-    const int totalLines = lines.count();
     QStringList keys;
     QStringList docu;
-    for (int i = 0; i < totalLines; ++i) {
+    foreach (QString line, lines) {
-        const QString &line = lines.at(i).trimmed();
+        line = line.trimmed();
         if ((line.startsWith(QLatin1String("--")) && !line.startsWith(QLatin1String("---")))
                 || line.startsWith(QLatin1String("OR "))) {
             QStringList rawKeys = line.split(QLatin1String(" OR "), QString::SkipEmptyParts);

src/plugins/beautifier/beautifierplugin.cpp

@@ -98,12 +98,11 @@ bool BeautifierPlugin::initialize(const QStringList &arguments, QString *errorSt
     menu->menu()->setTitle(QCoreApplication::translate("Beautifier", Constants::OPTION_TR_CATEGORY));
     Core::ActionManager::actionContainer(Core::Constants::M_TOOLS)->addMenu(menu);
 
-    for (int i = 0, total = m_tools.count(); i < total; ++i) {
+    foreach (BeautifierAbstractTool *tool, m_tools) {
-        BeautifierAbstractTool *tool = m_tools.at(i);
         tool->initialize();
         const QList<QObject *> autoReleasedObjects = tool->autoReleaseObjects();
-        for (int j = 0, total = autoReleasedObjects.count(); j < total; ++j)
+        foreach (QObject *object, autoReleasedObjects)
-            addAutoReleasedObject(autoReleasedObjects.at(j));
+            addAutoReleasedObject(object);
     }
 
     // The single shot is needed, otherwise the menu will stay disabled even
@@ -127,8 +126,8 @@ ExtensionSystem::IPlugin::ShutdownFlag BeautifierPlugin::aboutToShutdown()
 
 void BeautifierPlugin::updateActions(Core::IEditor *editor)
 {
-    for (int i = 0, total = m_tools.count(); i < total; ++i)
+    foreach (BeautifierAbstractTool *tool, m_tools)
-        m_tools.at(i)->updateActions(editor);
+        tool->updateActions(editor);
 }
 
 // Use pipeError() instead of calling showError() because this function may run in another thread.
@@ -323,9 +322,7 @@ void BeautifierPlugin::formatCurrentFileContinue(QObject *watcher)
     int newCursorPos = charactersInfrontOfCursor;
     cursor.beginEditBlock();
     cursor.movePosition(QTextCursor::Start, QTextCursor::MoveAnchor);
-    const int diffSize = diff.size();
+    foreach (const DiffEditor::Diff &d, diff) {
-    for (int i = 0; i < diffSize; ++i) {
-        const DiffEditor::Diff d = diff.at(i);
         switch (d.command) {
         case DiffEditor::Diff::Insert:
         {
@@ -396,9 +393,8 @@ void BeautifierPlugin::formatCurrentFileContinue(QObject *watcher)
                                               + absoluteVerticalCursorOffset / fontHeight);
     // Restore folded blocks
     const QTextDocument *doc = textEditor->document();
-    const int total = foldedBlocks.size();
+    foreach (const int blockId, foldedBlocks) {
-    for (int i = 0; i < total; ++i) {
+        QTextBlock block = doc->findBlockByNumber(qMax(0, blockId));
-        QTextBlock block = doc->findBlockByNumber(qMax(0, foldedBlocks.at(i)));
         if (block.isValid())
             TextDocumentLayout::doFoldOrUnfold(block, false);
     }

src/plugins/beautifier/clangformat/clangformatsettings.cpp

@@ -136,9 +136,7 @@ void ClangFormatSettings::createDocumentationFile() const
             << QLatin1String("TabWidth {unsigned}")
             << QLatin1String("UseTab {UseTabStyle: UT_Never, UT_ForIndentation, UT_Always}");
 
-    const int totalLines = lines.count();
+    foreach (const QString& line, lines) {
-    for (int i = 0; i < totalLines; ++i) {
-        const QString& line = lines.at(i);
         const int firstSpace = line.indexOf(QLatin1Char(' '));
         const QString keyword = line.left(firstSpace);
         const QString options = line.right(line.size() - firstSpace).trimmed();

src/plugins/beautifier/uncrustify/uncrustify.cpp

@@ -156,8 +156,7 @@ QString Uncrustify::configurationFile() const
         if (const ProjectExplorer::Project *project
                 = ProjectExplorer::ProjectTree::currentProject()) {
             const QStringList files = project->files(ProjectExplorer::Project::AllFiles);
-            for (int i = 0, total = files.size(); i < total; ++i) {
+            foreach (const QString &file, files) {
-                const QString &file = files.at(i);
                 if (!file.endsWith(QLatin1String("cfg")))
                     continue;
                 const QFileInfo fi(file);