feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Make the meaning of PathChooser::changed() consistent.

Browse Source 
This signal was emitted from two places. In one of them, the argument
was the pure string from the line edit, and in the other one the "raw
path", that is, the aforementioned string processed by cleanPath() and
fromNativeSeparators().
We now use the latter in both contexts. A look at the slots does not
suggest anyone is interested in the other value rather than this one.

Change-Id: Iacb6e0815004b2ef0107bfef03b97b46015da989
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Christian Kandeler
2015-08-20 12:00:16 +02:00
parent c760cbd2f9
commit 6c1458234b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/utils/pathchooser.cpp
View File

@@ -222,7 +222,7 @@ PathChooser::PathChooser(QWidget *parent) :
d->m_hLayout->setContentsMargins(0, 0, 0, 0);
connect(d->m_lineEdit, &FancyLineEdit::validReturnPressed, this, &PathChooser::returnPressed);
connect(d->m_lineEdit, &QLineEdit::textChanged, this, &PathChooser::changed);
connect(d->m_lineEdit, &QLineEdit::textChanged, this, [this] { emit changed(rawPath()); });
connect(d->m_lineEdit, &FancyLineEdit::validChanged, this, &PathChooser::validChanged);
connect(d->m_lineEdit, &QLineEdit::editingFinished, this, &PathChooser::editingFinished);
connect(d->m_lineEdit, &QLineEdit::textChanged, this, [this] { emit pathChanged(path()); });