Windows: Remove explicit usage of _WIN32_WINNT and WINVER macros

The are set in a central place, in the precompile header file.
Or as DEFAULT_DEFINES when the precompile header file is not used.

Change-Id: Ie020f916b64eabcd5a8153f4be5474986f5afed5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

cmake/QtCreatorAPI.cmake

@@ -15,6 +15,13 @@ list(APPEND DEFAULT_DEFINES
 
 if (WIN32)
   list(APPEND DEFAULT_DEFINES UNICODE _UNICODE _CRT_SECURE_NO_WARNINGS)
+
+  if (NOT BUILD_WITH_PCH)
+    # Windows 8 0x0602
+    list(APPEND DEFAULT_DEFINES
+      WINVER=0x0602 _WIN32_WINNT=0x0602
+      WIN32_LEAN_AND_MEAN)
+  endif()
 endif()
 
 #

src/libs/utils/fileutils.cpp

@@ -45,10 +45,6 @@
 #endif
 
 #ifdef Q_OS_WIN
-// We need defines for Windows 8
-#undef _WIN32_WINNT
-#define _WIN32_WINNT _WIN32_WINNT_WIN8
-
 #include <qt_windows.h>
 #include <shlobj.h>
 #endif

src/libs/utils/hostosinfo.cpp

@@ -32,8 +32,6 @@
 #endif
 
 #ifdef Q_OS_WIN
-#undef _WIN32_WINNT
-#define _WIN32_WINNT 0x0501 /* WinXP, needed for GetNativeSystemInfo() */
 #include <qt_windows.h>
 #endif
 

src/libs/utils/process_ctrlc_stub.cpp

@@ -36,7 +36,10 @@
 #define _WIN32_WINNT 0x0501
 #endif
 
+#ifndef WIN32_LEAN_AND_MEAN
 #define WIN32_LEAN_AND_MEAN
+#endif
+
 #include <windows.h>
 #include <shellapi.h>
 #include <wchar.h>

src/libs/utils/winutils.cpp

@@ -26,10 +26,7 @@
 #include "winutils.h"
 #include "qtcassert.h"
 
-// Enable WinAPI Windows Vista and later
 #ifdef Q_OS_WIN
-#undef _WIN32_WINNT
-#define _WIN32_WINNT 0x0600 // Needed for QueryFullProcessImageName
 #include <windows.h>
 #endif
 

src/plugins/debugger/procinterrupt.cpp

@@ -40,10 +40,6 @@ static inline QString msgCannotInterrupt(qint64 pid, const QString &why)
 }
 
 #if defined(Q_OS_WIN)
-
-#undef _WIN32_WINNT
-#define _WIN32_WINNT 0x0501 /* WinXP, needed for DebugBreakProcess() */
-
 #include <utils/winutils.h>
 #include <windows.h>
 

src/plugins/debugger/registerpostmortemaction.cpp

@@ -23,10 +23,6 @@
 **
 ****************************************************************************/
 
-#ifndef _WIN32_WINNT
-#define _WIN32_WINNT 0x0400
-#endif
-
 #include "registerpostmortemaction.h"
 
 #include <registryaccess.h>

src/plugins/debugger/shared/hostutils.cpp

@@ -28,10 +28,6 @@
 #ifdef Q_OS_WIN
 
 #include <QTextStream>
-
-// Enable Win API of XP SP1 and later
-#undef _WIN32_WINNT
-#define _WIN32_WINNT 0x0502
 #include <windows.h>
 #include <utils/winutils.h>
 #include <tlhelp32.h>

src/plugins/projectexplorer/devicesupport/desktopprocesssignaloperation.cpp

@@ -36,7 +36,6 @@
 #include <QProcess>
 
 #ifdef Q_OS_WIN
-#define _WIN32_WINNT 0x0502
 #include <windows.h>
 #ifndef PROCESS_SUSPEND_RESUME
 #define PROCESS_SUSPEND_RESUME 0x0800

src/plugins/projectexplorer/devicesupport/localprocesslist.cpp

@@ -40,9 +40,6 @@
 #endif
 
 #ifdef Q_OS_WIN
-// Enable Win API of XP SP1 and later
-#undef _WIN32_WINNT
-#define _WIN32_WINNT 0x0502
 #include <windows.h>
 #include <utils/winutils.h>
 #include <tlhelp32.h>

src/shared/qtcreator_pch.h

@@ -31,24 +31,31 @@
 #if defined __cplusplus
 #include <QtGlobal>
 
-#ifdef Q_WS_WIN
+#ifdef Q_OS_WIN
-# define _POSIX_
+#undef WIN32_LEAN_AND_MEAN
-# include <limits.h>
+#define WIN32_LEAN_AND_MEAN
-# undef _POSIX_
-#endif
 
-#include <QCoreApplication>
+// lib/Utils needs defines for Windows 8
-#include <QList>
+#undef WINVER
-#include <QVariant>
+#define WINVER 0x0602
-#include <QObject>
+#undef _WIN32_WINNT
-#include <QRegExp>
+#define _WIN32_WINNT 0x0602
-#include <QString>
+
-#include <QStringList>
+#define NOHELP
-#include <QTextCodec>
+#include <qt_windows.h>
-#include <QPointer>
+
-#include <QScopedPointer>
+#undef DELETE
-#include <QSharedPointer>
+#undef IN
-#include <QDebug>
+#undef OUT
+#undef ERROR
+#undef ABSOLUTE
+
+#define _POSIX_
+#include <limits.h>
+#undef _POSIX_
+#endif // Q_OS_WIN
+
+#include <QtCore>
 
 #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
 #include <QTextStream>