feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Preserve selections in commit editor on refresh

Browse Source 
Task-number: QTCREATORBUG-18483
Change-Id: I749f2d4d583f197e7b5b6f69116c3a196e85484b
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2017-06-29 23:55:02 +03:00
committed by Orgad Shaneh
parent caaf370660
commit 6c70f22ada
3 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/plugins/vcsbase/submiteditorwidget.cpp
View File

@@ -28,6 +28,8 @@
#include "submitfilemodel.h"
#include "ui_submiteditorwidget.h"
#include <utils/algorithm.h>
#include <QDebug>
#include <QPointer>
#include <QTextBlock>
@@ -117,18 +119,6 @@ public slots:
// Helpers to retrieve model data
// Convenience to extract a list of selected indexes
QList<int> selectedRows(const QAbstractItemView *view)
{
const QModelIndexList indexList = view->selectionModel()->selectedRows(0);
if (indexList.empty())
return QList<int>();
QList<int> rc;
const QModelIndexList::const_iterator cend = indexList.constEnd();
for (QModelIndexList::const_iterator it = indexList.constBegin(); it != cend; ++it)
rc.push_back(it->row());
return rc;
}
// ----------- SubmitEditorWidgetPrivate
struct SubmitEditorWidgetPrivate
@@ -463,7 +453,7 @@ Utils::CompletingTextEdit *SubmitEditorWidget::descriptionEdit() const
void SubmitEditorWidget::triggerDiffSelected()
{
const QList<int> sel = selectedRows(d->m_ui.fileView);
const QList<int> sel = selectedRows();
if (!sel.empty())
emit diffSelected(sel);
}
@@ -610,6 +600,22 @@ bool SubmitEditorWidget::updateInProgress() const
return d->m_updateInProgress;
}
QList<int> SubmitEditorWidget::selectedRows() const
{
return Utils::transform(d->m_ui.fileView->selectionModel()->selectedRows(0), &QModelIndex::row);
}
void SubmitEditorWidget::setSelectedRows(const QList<int> &rows)
{
if (const SubmitFileModel *model = fileModel()) {
QItemSelectionModel *selectionModel = d->m_ui.fileView->selectionModel();
for (int row : rows) {
selectionModel->select(model->index(row, 0),
QItemSelectionModel::Select | QItemSelectionModel::Rows);
}
}
}
QString SubmitEditorWidget::commitName() const
{
return tr("&Commit");