feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove ProcessParameters::resolveAll()

Browse Source 
On all code paths, this was implicit in a ProcessParameters::setCommandLine()
which was on all code paths either called directly immediately before, or as
part of ProcessStep::setupProcessParameters().

With ProcessParameters::setCommandLine() as only user, this could be
inlined there. The effectiveWorkingDirectory() turned out to be out of
place and rather accidentally working there and was moved to
ProcessParameters::setWorkingDirectory().

Change-Id: I634f6086c2324e3cbecd3e5d50e22afc722abd3f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-08-25 02:33:43 +02:00
parent 4b98cadb3a
commit 6c785c05ab
7 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -250,7 +250,6 @@ bool CMakeBuildStep::init()
ProcessParameters *pp = processParameters();
setupProcessParameters(pp);
pp->setCommandLine(cmakeCommand(rc));
pp->resolveAll();
return AbstractProcessStep::init();
}