forked from qt-creator/qt-creator
ProjectExplorer: Remove ProcessParameters::resolveAll()
On all code paths, this was implicit in a ProcessParameters::setCommandLine() which was on all code paths either called directly immediately before, or as part of ProcessStep::setupProcessParameters(). With ProcessParameters::setCommandLine() as only user, this could be inlined there. The effectiveWorkingDirectory() turned out to be out of place and rather accidentally working there and was moved to ProcessParameters::setWorkingDirectory(). Change-Id: I634f6086c2324e3cbecd3e5d50e22afc722abd3f Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -162,7 +162,6 @@ bool QmakeMakeStep::init()
|
||||
|
||||
pp->setEnvironment(makeEnvironment());
|
||||
pp->setCommandLine(makeCmd);
|
||||
pp->resolveAll();
|
||||
|
||||
auto rootNode = dynamic_cast<QmakeProFileNode *>(project()->rootProjectNode());
|
||||
QTC_ASSERT(rootNode, return false);
|
||||
|
||||
Reference in New Issue
Block a user