feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Session manager will no longer try to load a session when clicking OK.

Browse Source 
This double role of managing sessions *and* loading the active one was
always a bit odd and confusing (unexpected behavior).

Reviewed-By: dt
This commit is contained in:
Daniel Molkentin
2009-06-05 17:28:33 +02:00
parent 98981a6700
commit 6c7f03e29e
2 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/sessiondialog.cpp
View File

@@ -139,15 +139,13 @@ void SessionDialog::updateActions()
if (m_ui.sessionList->currentItem()) if (m_ui.sessionList->currentItem())
enableDelete = (m_ui.sessionList->currentItem()->text() != m_sessionManager->activeSession() enableDelete = (m_ui.sessionList->currentItem()->text() != m_sessionManager->activeSession()
&& m_ui.sessionList->currentItem()->text() != "default"); && (m_ui.sessionList->currentItem()->text() != QLatin1String("default")));
m_ui.btDelete->setEnabled(enableDelete); m_ui.btDelete->setEnabled(enableDelete);
} }
void SessionDialog::accept() void SessionDialog::accept()
{ {
if (m_ui.sessionList->currentItem()) { // do nothing
m_sessionManager->loadSession(m_ui.sessionList->currentItem()->text());
}
QDialog::accept(); QDialog::accept();
} }

15
src/plugins/projectexplorer/sessiondialog.ui
View File

@@ -14,17 +14,10 @@
<string>Session Manager</string> <string>Session Manager</string>
</property> </property>
<layout class="QGridLayout" name="gridLayout"> <layout class="QGridLayout" name="gridLayout">
<item row="0" column="0"> <item row="0" column="0" colspan="2">
<widget class="QLabel" name="label">
<property name="text">
<string>Choose your session</string>
</property>
</widget>
</item>
<item row="1" column="0" colspan="2">
<widget class="QListWidget" name="sessionList"/> <widget class="QListWidget" name="sessionList"/>
</item> </item>
<item row="1" column="2"> <item row="0" column="2">
<layout class="QVBoxLayout" name="verticalLayout"> <layout class="QVBoxLayout" name="verticalLayout">
<item> <item>
<widget class="QPushButton" name="btCreateNew"> <widget class="QPushButton" name="btCreateNew">
@@ -62,14 +55,14 @@
</item> </item>
</layout> </layout>
</item> </item>
<item row="2" column="0"> <item row="1" column="0">
<widget class="QLabel" name="whatsASessionLabel"> <widget class="QLabel" name="whatsASessionLabel">
<property name="text"> <property name="text">
<string>&lt;a href=&quot;qthelp://com.nokia.qtcreator/doc/creator-quick-tour.html#session-management-in-qt-creator&quot;&gt;What is a Session?&lt;/a&gt;</string> <string>&lt;a href=&quot;qthelp://com.nokia.qtcreator/doc/creator-quick-tour.html#session-management-in-qt-creator&quot;&gt;What is a Session?&lt;/a&gt;</string>
</property> </property>
</widget> </widget>
</item> </item>
<item row="2" column="1" colspan="2"> <item row="1" column="1" colspan="2">
<widget class="QDialogButtonBox" name="buttonBox"> <widget class="QDialogButtonBox" name="buttonBox">
<property name="standardButtons"> <property name="standardButtons">
<set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set> <set>QDialogButtonBox::Cancel|QDialogButtonBox::Ok</set>