From 6cc47de5b1f02cb5a741c6717c4118ec02520ffa Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Thu, 20 Oct 2022 12:16:52 +0200 Subject: [PATCH] PE: Do not use setVisible() before having a parent Fixes shortly popping up floating widget on the Build & Run settings page. Change-Id: I8bcc887ae73b9cb27f690548d0e98038fb757674 Reviewed-by: David Schulz --- src/plugins/projectexplorer/projectexplorersettingspage.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/projectexplorer/projectexplorersettingspage.cpp b/src/plugins/projectexplorer/projectexplorersettingspage.cpp index 5684580d71a..570c44e67b7 100644 --- a/src/plugins/projectexplorer/projectexplorersettingspage.cpp +++ b/src/plugins/projectexplorer/projectexplorersettingspage.cpp @@ -107,7 +107,6 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) : m_terminalModeComboBox->addItem(tr("Deduced from Project")); m_terminalModeComboBox->setSizePolicy(cbSizePolicy); m_jomCheckbox = new QCheckBox(tr("Use jom instead of nmake")); - m_jomCheckbox->setVisible(HostOsInfo::isWindowsHost()); auto jomLabel = new QLabel("jom is a drop-in replacement for nmake which " "distributes the compilation process to multiple CPU cores. " "The latest binary is available at " @@ -115,7 +114,6 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) : "http://download.qt.io/official_releases/jom/. " "Disable it if you experience problems with your builds."); jomLabel->setWordWrap(true); - jomLabel->setVisible(HostOsInfo::isWindowsHost()); using namespace Utils::Layouting; Column { @@ -155,6 +153,9 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) : st, }.attachTo(this); + m_jomCheckbox->setVisible(HostOsInfo::isWindowsHost()); + jomLabel->setVisible(HostOsInfo::isWindowsHost()); + m_directoryButtonGroup = new QButtonGroup; m_directoryButtonGroup->setExclusive(true); m_directoryButtonGroup->addButton(m_currentDirectoryRadioButton, UseCurrentDirectory);