feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warnings about QFileInfo being instantiated on empty string.

Browse Source 
Do not insert currentDocument variable for empty files.
Polish VariableManager, QLatin1String(), const-correctness.

Reviewed-by: Daniel Molkentin <daniel.molkentin@nokia.com>
This commit is contained in:
Friedemann Kleint
2010-01-04 16:50:23 +01:00
parent 23fc1afe1f
commit 6cf0247bd6
2 changed files with 46 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/coreplugin/variablemanager.h
View File

@@ -56,10 +56,10 @@ public:
void insert(const QString &variable, const QString &value);
void insertFileInfo(const QString &tag, const QFileInfo &file);
void removeFileInfo(const QString &tag);
QString value(const QString &variable);
QString value(const QString &variable, const QString &defaultValue);
void remove(const QString &variable);
QString resolve(const QString &stringWithVariables);
QString value(const QString &variable) const;
QString value(const QString &variable, const QString &defaultValue) const;
bool remove(const QString &variable);
QString resolve(const QString &stringWithVariables) const;
private slots:
void updateCurrentDocument(Core::IEditor *editor);