feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QbsProjectManager: Fix crash at project closing

Browse Source 
The QbsProjectParser was mistakenly made the parent object of the qbs
build job.

Task-number: QTCREATORBUG-16273
Change-Id: I8e0f9736ac9d92c5c1fe3d82430532358b78fee4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Kandeler
2016-07-19 13:59:46 +02:00
committed by Christian Kandeler
parent 6a52c34055
commit 6d4b944683
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qbsprojectmanager/qbsprojectparser.cpp
View File

@@ -158,7 +158,7 @@ void QbsProjectParser::startRuleExecution()
options.setDryRun(m_dryRun); options.setDryRun(m_dryRun);
options.setExecuteRulesOnly(true); options.setExecuteRulesOnly(true);
m_ruleExecutionJob = m_project.buildAllProducts( m_ruleExecutionJob = m_project.buildAllProducts(
options, qbs::Project::ProductSelectionWithNonDefault, this); options, qbs::Project::ProductSelectionWithNonDefault, nullptr);
connect(m_ruleExecutionJob, &qbs::AbstractJob::finished, connect(m_ruleExecutionJob, &qbs::AbstractJob::finished,
this, &QbsProjectParser::handleRuleExecutionDone); this, &QbsProjectParser::handleRuleExecutionDone);
connect(m_ruleExecutionJob, &qbs::AbstractJob::taskStarted, connect(m_ruleExecutionJob, &qbs::AbstractJob::taskStarted,