From 6d50a5e36ee609d73c67b0b8db66719d9cafe64f Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 5 Apr 2022 16:27:46 +0200 Subject: [PATCH] Archive: Connect to QtcProcess::done() signal Instead of connecting to errorOccurred() and finished() signals. Change-Id: I2bc4b8359652549949c486ad6bce002a5db30688 Reviewed-by: Eike Ziller --- src/libs/utils/archive.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/libs/utils/archive.cpp b/src/libs/utils/archive.cpp index fcef2c22b04..9ff64a5a91c 100644 --- a/src/libs/utils/archive.cpp +++ b/src/libs/utils/archive.cpp @@ -186,12 +186,11 @@ void Archive::unarchive() QObject::connect(m_process.get(), &QtcProcess::readyReadStandardOutput, this, [this] { emit outputReceived(QString::fromUtf8(m_process->readAllStandardOutput())); }); - QObject::connect(m_process.get(), &QtcProcess::finished, this, [this] { - emit finished(m_process->result() == ProcessResult::FinishedWithSuccess); - }); - QObject::connect(m_process.get(), &QtcProcess::errorOccurred, this, [this] { - emit outputReceived(tr("Command failed.")); - emit finished(false); + QObject::connect(m_process.get(), &QtcProcess::done, this, [this] { + const bool successfulFinish = m_process->result() == ProcessResult::FinishedWithSuccess; + if (!successfulFinish) + emit outputReceived(tr("Command failed.")); + emit finished(successfulFinish); }); emit outputReceived(tr("Running %1\nin \"%2\".\n\n", "Running in ")