From f1a5939e86c6df4d76e9e79c8d4bf93695d8c517 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Mon, 29 Jun 2020 02:01:18 +0200 Subject: [PATCH 1/8] Android: Fix default (Android Studio) Sdk path for Windows By default, Android Studio on Windows puts the SDK into: %LOCALAPPDATA%\Android\Sdk Change-Id: Iadbb1cb5c15c6cdb581cbe07b2a0e83ac11e384e Reviewed-by: Assam Boudjelthia --- src/plugins/android/androidsettingswidget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/android/androidsettingswidget.cpp b/src/plugins/android/androidsettingswidget.cpp index b5aa0455897..b004ec4d5f3 100644 --- a/src/plugins/android/androidsettingswidget.cpp +++ b/src/plugins/android/androidsettingswidget.cpp @@ -308,7 +308,8 @@ FilePath AndroidSettingsWidget::getDefaultSdkPath() const if (HostOsInfo::isWindowsHost()) { return FilePath::fromString( - QStandardPaths::writableLocation(QStandardPaths::HomeLocation) + "/Android/sdk"); + QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + + "/Android/Sdk"); } return FilePath::fromString( From ddde374b4013af74dc1238e3b77612f60bf478b9 Mon Sep 17 00:00:00 2001 From: Henning Gruendl Date: Mon, 29 Jun 2020 12:01:15 +0200 Subject: [PATCH 2/8] QmlDesigner: Set height according to active tab * Add binding to current tab height * Remove unused specficsOneHeight statement Task-number: QDS-2051 Change-Id: Ia1ac6af4e65d3de5e1db96f2bcc2d1ec8eb08312 Reviewed-by: Thomas Hartmann --- .../QtQuick/ItemPane.qml | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml index 41abe776cec..25b0d498548 100644 --- a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml +++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml @@ -325,12 +325,10 @@ Rectangle { frameVisible: false id: tabView - height: Math.max(layoutSectionHeight, specficsHeight, advancedHeight) + extraHeight - property int advancedHeight: 0 - property int layoutSectionHeight: 0 - property int specficsHeight: 0 + height: currentHeight + extraHeight + property int currentHeight: getTab(currentIndex).item.implicitHeight property int extraHeight: 40 Tab { @@ -340,8 +338,6 @@ Rectangle { anchors.left: parent.left anchors.right: parent.right - onImplicitHeightChanged: tabView.specficsHeight = implicitHeight - Loader { anchors.left: parent.left anchors.right: parent.right @@ -366,11 +362,6 @@ Rectangle { source: specificsUrl; property int loaderHeight: specificsOne.item.height + tabView.extraHeight - onLoaderHeightChanged: tabView.specficsOneHeight = loaderHeight - - onLoaded: { - tabView.specficsOneHeight = loaderHeight - } } } } @@ -381,8 +372,6 @@ Rectangle { anchors.left: parent.left anchors.right: parent.right - onImplicitHeightChanged: tabView.layoutSectionHeight = implicitHeight - LayoutSection { } @@ -713,8 +702,6 @@ Rectangle { anchors.left: parent.left anchors.right: parent.right - onImplicitHeightChanged: tabView.advancedHeight = implicitHeight - AdvancedSection { } LayerSection { From 7f0a0d2c60c12b73fc71fa1f54c2af271c161e3c Mon Sep 17 00:00:00 2001 From: Henning Gruendl Date: Mon, 29 Jun 2020 12:31:38 +0200 Subject: [PATCH 3/8] QmlDesigner: Property Editor cleanup * Put align distribute section in separate file Change-Id: I8f0219f32f847c11733833164c5287af5df429cd Reviewed-by: Thomas Hartmann --- .../QtQuick/AlignDistributeSection.qml | 338 ++++++++++++++++++ .../QtQuick/ItemPane.qml | 307 +--------------- 2 files changed, 339 insertions(+), 306 deletions(-) create mode 100644 share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/AlignDistributeSection.qml diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/AlignDistributeSection.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/AlignDistributeSection.qml new file mode 100644 index 00000000000..36f4c026429 --- /dev/null +++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/AlignDistributeSection.qml @@ -0,0 +1,338 @@ +/**************************************************************************** +** +** Copyright (C) 2020 The Qt Company Ltd. +** Contact: https://www.qt.io/licensing/ +** +** This file is part of Qt Creator. +** +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and The Qt Company. For licensing terms +** and conditions see https://www.qt.io/terms-conditions. For further +** information use the contact form at https://www.qt.io/contact-us. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3 as published by the Free Software +** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT +** included in the packaging of this file. Please review the following +** information to ensure the GNU General Public License requirements will +** be met: https://www.gnu.org/licenses/gpl-3.0.html. +** +****************************************************************************/ + +import QtQuick 2.0 +import HelperWidgets 2.0 +import QtQuick.Layouts 1.0 +import StudioControls 1.0 as StudioControls +import StudioTheme 1.0 as StudioTheme + +Section { + anchors.left: parent.left + anchors.right: parent.right + caption: qsTr("Align") + + ColumnLayout { + width: parent.width + enabled: alignDistribute.multiSelection && + !alignDistribute.selectionHasAnchors && + alignDistribute.selectionExclusivlyItems && + !alignDistribute.selectionContainsRootItem + + AlignDistribute { + id: alignDistribute + modelNodeBackendProperty: modelNodeBackend + } + + Label { + text: qsTr("Align objects") + width: 120 + } + RowLayout { + Row { + spacing: -StudioTheme.Values.border + AbstractButton { + buttonIcon: StudioTheme.Constants.alignLeft + tooltip: qsTr("Align left edges.") + onClicked: alignDistribute.alignObjects(AlignDistribute.Left, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.alignCenterHorizontal + tooltip: qsTr("Align horizontal centers.") + onClicked: alignDistribute.alignObjects(AlignDistribute.CenterH, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.alignRight + tooltip: qsTr("Align right edges.") + onClicked: alignDistribute.alignObjects(AlignDistribute.Right, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + } + + Row { + spacing: -StudioTheme.Values.border + AbstractButton { + buttonIcon: StudioTheme.Constants.alignTop + tooltip: qsTr("Align top edges.") + onClicked: alignDistribute.alignObjects(AlignDistribute.Top, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.alignCenterVertical + tooltip: qsTr("Align vertical centers.") + onClicked: alignDistribute.alignObjects(AlignDistribute.CenterV, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.alignBottom + tooltip: qsTr("Align bottom edges.") + onClicked: alignDistribute.alignObjects(AlignDistribute.Bottom, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + } + } + + Label { + text: qsTr("Distribute objects") + width: 120 + } + RowLayout { + Row { + spacing: -StudioTheme.Values.border + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeLeft + tooltip: qsTr("Distribute left edges.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.Left, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeCenterHorizontal + tooltip: qsTr("Distribute horizontal centers.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.CenterH, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeRight + tooltip: qsTr("Distribute right edges.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.Right, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + } + + Row { + spacing: -StudioTheme.Values.border + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeTop + tooltip: qsTr("Distribute top edges.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.Top, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeCenterVertical + tooltip: qsTr("Distribute vertical centers.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.CenterV, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeBottom + tooltip: qsTr("Distribute bottom edges.") + onClicked: alignDistribute.distributeObjects(AlignDistribute.Bottom, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText) + } + } + } + + Label { + text: qsTr("Distribute spacing") + width: 120 + } + RowLayout { + Row { + spacing: -StudioTheme.Values.border + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeSpacingHorizontal + tooltip: qsTr("Distribute spacing horizontally.") + onClicked: alignDistribute.distributeSpacing(AlignDistribute.X, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText, + distanceSpinBox.realValue, + buttonRow.getDistributeDirection()) + } + AbstractButton { + buttonIcon: StudioTheme.Constants.distributeSpacingVertical + tooltip: qsTr("Distribute spacing vertically.") + onClicked: alignDistribute.distributeSpacing(AlignDistribute.Y, + alignToComboBox.currentEnum, + keyObjectComboBox.currentText, + distanceSpinBox.realValue, + buttonRow.getDistributeDirection()) + } + } + + StudioControls.ButtonRow { + id: buttonRow + actionIndicatorVisible: false + + StudioControls.ButtonGroup { + id: group + } + + function getDistributeDirection() + { + if (buttonLeftToRight.checked) + return AlignDistribute.TopLeft + else if (buttonCenter.checked) + return AlignDistribute.Center + else if (buttonRightToLeft.checked) + return AlignDistribute.BottomRight + else + return AlignDistribute.None + } + + AbstractButton { + id: buttonNone + checked: true // default state + buttonIcon: StudioTheme.Constants.distributeOriginNone + checkable: true + StudioControls.ButtonGroup.group: group + } + AbstractButton { + id: buttonLeftToRight + buttonIcon: StudioTheme.Constants.distributeOriginTopLeft + checkable: true + StudioControls.ButtonGroup.group: group + } + AbstractButton { + id: buttonCenter + buttonIcon: StudioTheme.Constants.distributeOriginCenter + checkable: true + StudioControls.ButtonGroup.group: group + } + AbstractButton { + id: buttonRightToLeft + buttonIcon: StudioTheme.Constants.distributeOriginBottomRight + checkable: true + StudioControls.ButtonGroup.group: group + } + + StudioControls.RealSpinBox { + id: distanceSpinBox + width: 64 + actionIndicatorVisible: false + realFrom: -1000 + realTo: 1000 + enabled: !buttonNone.checked + } + } + } + + SectionLayout { + columns: 2 + + ItemFilterModel { + id: itemFilterModel + modelNodeBackendProperty: modelNodeBackend + selectionOnly: true + } + + Label { + text: qsTr("Align to") + } + ComboBox { + id: alignToComboBox + Layout.fillWidth: true + property int currentEnum: alignTargets.get(alignToComboBox.currentIndex).value + textRole: "text" + model: ListModel { + id: alignTargets + ListElement { text: "Selection"; value: AlignDistribute.Selection } + ListElement { text: "Root"; value: AlignDistribute.Root } + ListElement { text: "Key object"; value: AlignDistribute.KeyObject } + } + } + + Label { + text: qsTr("Key object") + } + ComboBox { + id: keyObjectComboBox + enabled: alignToComboBox.currentIndex === 2 + model: itemFilterModel.itemModel + Layout.fillWidth: true + property string lastSelectedItem: "" + onCompressedActivated: lastSelectedItem = keyObjectComboBox.currentText + onModelChanged: { + var idx = model.indexOf(keyObjectComboBox.lastSelectedItem) + if (idx !== -1) + keyObjectComboBox.currentIndex = idx + else + lastSelectedItem = "" // TODO + } + } + } + + SectionLayout { + columns: 1 + Layout.topMargin: 30 + visible: alignDistribute.multiSelection && + (alignDistribute.selectionHasAnchors || + !alignDistribute.selectionExclusivlyItems || + alignDistribute.selectionContainsRootItem) + + Text { + id: warningTitle + font.family: StudioTheme.Constants.font.family + font.pixelSize: StudioTheme.Values.myFontSize + font.weight: Font.Bold + color: StudioTheme.Values.themeTextColor + text: qsTr("Warning") + } + Text { + id: warningRoot + visible: alignDistribute.selectionContainsRootItem + Layout.fillWidth: true + font.family: StudioTheme.Constants.font.family + font.pixelSize: StudioTheme.Values.myFontSize + color: StudioTheme.Values.themeTextColor + wrapMode: Text.WordWrap + text: qsTr("- The selection contains the root item.") + } + Text { + id: warningNonVisual + visible: !alignDistribute.selectionExclusivlyItems + Layout.fillWidth: true + font.family: StudioTheme.Constants.font.family + font.pixelSize: StudioTheme.Values.myFontSize + color: StudioTheme.Values.themeTextColor + wrapMode: Text.WordWrap + text: qsTr("- The selection contains a non visual item.") + } + Text { + id: warningAnchors + visible: alignDistribute.selectionHasAnchors + Layout.fillWidth: true + font.family: StudioTheme.Constants.font.family + font.pixelSize: StudioTheme.Values.myFontSize + color: StudioTheme.Values.themeTextColor + wrapMode: Text.WordWrap + text: qsTr("- An item in the selection uses anchors.") + } + } + } +} diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml index 25b0d498548..d66b50da0b6 100644 --- a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml +++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml @@ -384,313 +384,8 @@ Rectangle { backendValueMargins: backendValues.Layout_margins } - Section { + AlignDistributeSection { visible: !anchorBackend.isInLayout - anchors.left: parent.left - anchors.right: parent.right - caption: qsTr("Align") - - ColumnLayout { - width: parent.width - enabled: alignDistribute.multiSelection && - !alignDistribute.selectionHasAnchors && - alignDistribute.selectionExclusivlyItems && - !alignDistribute.selectionContainsRootItem - - AlignDistribute { - id: alignDistribute - modelNodeBackendProperty: modelNodeBackend - } - - Label { - text: qsTr("Align objects") - width: 120 - } - RowLayout { - Row { - spacing: -StudioTheme.Values.border - AbstractButton { - buttonIcon: StudioTheme.Constants.alignLeft - tooltip: qsTr("Align left edges.") - onClicked: alignDistribute.alignObjects(AlignDistribute.Left, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.alignCenterHorizontal - tooltip: qsTr("Align horizontal centers.") - onClicked: alignDistribute.alignObjects(AlignDistribute.CenterH, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.alignRight - tooltip: qsTr("Align right edges.") - onClicked: alignDistribute.alignObjects(AlignDistribute.Right, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - } - - Row { - spacing: -StudioTheme.Values.border - AbstractButton { - buttonIcon: StudioTheme.Constants.alignTop - tooltip: qsTr("Align top edges.") - onClicked: alignDistribute.alignObjects(AlignDistribute.Top, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.alignCenterVertical - tooltip: qsTr("Align vertical centers.") - onClicked: alignDistribute.alignObjects(AlignDistribute.CenterV, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.alignBottom - tooltip: qsTr("Align bottom edges.") - onClicked: alignDistribute.alignObjects(AlignDistribute.Bottom, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - } - } - - Label { - text: qsTr("Distribute objects") - width: 120 - } - RowLayout { - Row { - spacing: -StudioTheme.Values.border - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeLeft - tooltip: qsTr("Distribute left edges.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.Left, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeCenterHorizontal - tooltip: qsTr("Distribute horizontal centers.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.CenterH, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeRight - tooltip: qsTr("Distribute right edges.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.Right, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - } - - Row { - spacing: -StudioTheme.Values.border - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeTop - tooltip: qsTr("Distribute top edges.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.Top, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeCenterVertical - tooltip: qsTr("Distribute vertical centers.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.CenterV, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeBottom - tooltip: qsTr("Distribute bottom edges.") - onClicked: alignDistribute.distributeObjects(AlignDistribute.Bottom, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText) - } - } - } - - Label { - text: qsTr("Distribute spacing") - width: 120 - } - RowLayout { - Row { - spacing: -StudioTheme.Values.border - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeSpacingHorizontal - tooltip: qsTr("Distribute spacing horizontally.") - onClicked: alignDistribute.distributeSpacing(AlignDistribute.X, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText, - distanceSpinBox.realValue, - buttonRow.getDistributeDirection()) - } - AbstractButton { - buttonIcon: StudioTheme.Constants.distributeSpacingVertical - tooltip: qsTr("Distribute spacing vertically.") - onClicked: alignDistribute.distributeSpacing(AlignDistribute.Y, - alignToComboBox.currentEnum, - keyObjectComboBox.currentText, - distanceSpinBox.realValue, - buttonRow.getDistributeDirection()) - } - } - - StudioControls.ButtonRow { - id: buttonRow - actionIndicatorVisible: false - - StudioControls.ButtonGroup { - id: group - } - - function getDistributeDirection() - { - if (buttonLeftToRight.checked) - return AlignDistribute.TopLeft - else if (buttonCenter.checked) - return AlignDistribute.Center - else if (buttonRightToLeft.checked) - return AlignDistribute.BottomRight - else - return AlignDistribute.None - } - - AbstractButton { - id: buttonNone - checked: true // default state - buttonIcon: StudioTheme.Constants.distributeOriginNone - checkable: true - StudioControls.ButtonGroup.group: group - } - AbstractButton { - id: buttonLeftToRight - buttonIcon: StudioTheme.Constants.distributeOriginTopLeft - checkable: true - StudioControls.ButtonGroup.group: group - } - AbstractButton { - id: buttonCenter - buttonIcon: StudioTheme.Constants.distributeOriginCenter - checkable: true - StudioControls.ButtonGroup.group: group - } - AbstractButton { - id: buttonRightToLeft - buttonIcon: StudioTheme.Constants.distributeOriginBottomRight - checkable: true - StudioControls.ButtonGroup.group: group - } - - StudioControls.RealSpinBox { - id: distanceSpinBox - width: 64 - actionIndicatorVisible: false - realFrom: -1000 - realTo: 1000 - enabled: !buttonNone.checked - } - } - } - - SectionLayout { - columns: 2 - - ItemFilterModel { - id: itemFilterModel - modelNodeBackendProperty: modelNodeBackend - selectionOnly: true - } - - Label { - text: qsTr("Align to") - } - ComboBox { - id: alignToComboBox - Layout.fillWidth: true - property int currentEnum: alignTargets.get(alignToComboBox.currentIndex).value - textRole: "text" - model: ListModel { - id: alignTargets - ListElement { text: "Selection"; value: AlignDistribute.Selection } - ListElement { text: "Root"; value: AlignDistribute.Root } - ListElement { text: "Key object"; value: AlignDistribute.KeyObject } - } - } - - Label { - text: qsTr("Key object") - } - ComboBox { - id: keyObjectComboBox - enabled: alignToComboBox.currentIndex === 2 - model: itemFilterModel.itemModel - Layout.fillWidth: true - property string lastSelectedItem: "" - onCompressedActivated: lastSelectedItem = keyObjectComboBox.currentText - onModelChanged: { - var idx = model.indexOf(keyObjectComboBox.lastSelectedItem) - if (idx !== -1) - keyObjectComboBox.currentIndex = idx - else - lastSelectedItem = "" // TODO - } - } - } - - SectionLayout { - columns: 1 - Layout.topMargin: 30 - visible: alignDistribute.multiSelection && - (alignDistribute.selectionHasAnchors || - !alignDistribute.selectionExclusivlyItems || - alignDistribute.selectionContainsRootItem) - - Text { - id: warningTitle - font.family: StudioTheme.Constants.font.family - font.pixelSize: StudioTheme.Values.myFontSize - font.weight: Font.Bold - color: StudioTheme.Values.themeTextColor - text: qsTr("Warning") - } - Text { - id: warningRoot - visible: alignDistribute.selectionContainsRootItem - Layout.fillWidth: true - font.family: StudioTheme.Constants.font.family - font.pixelSize: StudioTheme.Values.myFontSize - color: StudioTheme.Values.themeTextColor - wrapMode: Text.WordWrap - text: qsTr("- The selection contains the root item.") - } - Text { - id: warningNonVisual - visible: !alignDistribute.selectionExclusivlyItems - Layout.fillWidth: true - font.family: StudioTheme.Constants.font.family - font.pixelSize: StudioTheme.Values.myFontSize - color: StudioTheme.Values.themeTextColor - wrapMode: Text.WordWrap - text: qsTr("- The selection contains a non visual item.") - } - Text { - id: warningAnchors - visible: alignDistribute.selectionHasAnchors - Layout.fillWidth: true - font.family: StudioTheme.Constants.font.family - font.pixelSize: StudioTheme.Values.myFontSize - color: StudioTheme.Values.themeTextColor - wrapMode: Text.WordWrap - text: qsTr("- An item in the selection uses anchors.") - } - } - } } } } From 09cb6d0d1e737aa20975288d2dfaf0e669a4326d Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Wed, 24 Jun 2020 13:29:16 +0200 Subject: [PATCH 4/8] McuSupport: Bump supported Qt for MCUs version from 1.2 to 1.3 Task-number: QTCREATORBUG-24203 Change-Id: I378dca375bcd9a533c585369bb61c2c329a8a1d1 Reviewed-by: Alessandro Portale --- src/plugins/mcusupport/mcusupportoptions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/mcusupport/mcusupportoptions.cpp b/src/plugins/mcusupport/mcusupportoptions.cpp index ce182bd070f..937342fdc5a 100644 --- a/src/plugins/mcusupport/mcusupportoptions.cpp +++ b/src/plugins/mcusupport/mcusupportoptions.cpp @@ -61,7 +61,7 @@ namespace McuSupport { namespace Internal { -static const int KIT_VERSION = 5; // Bumps up whenever details in Kit creation change +static const int KIT_VERSION = 6; // Bumps up whenever details in Kit creation change static QString packagePathFromSettings(const QString &settingsKey, QSettings::Scope scope = QSettings::UserScope, @@ -452,7 +452,7 @@ void McuSupportOptions::deletePackagesAndTargets() const QVersionNumber &McuSupportOptions::supportedQulVersion() { - static const QVersionNumber v({1, 2}); + static const QVersionNumber v({1, 3}); return v; } From 1e4166b850ecad11e8ddd591704341f1b2370cf9 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Mon, 29 Jun 2020 21:24:13 +0000 Subject: [PATCH 5/8] Revert "McuSupport: Bump supported Qt for MCUs version from 1.2 to 1.3" This reverts commit 09cb6d0d1e737aa20975288d2dfaf0e669a4326d. Reason for revert: Change-Id: I463f10f1f25e610d1e7b9e8d84d8a8564f5a26f3 Reviewed-by: Alessandro Portale --- src/plugins/mcusupport/mcusupportoptions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/mcusupport/mcusupportoptions.cpp b/src/plugins/mcusupport/mcusupportoptions.cpp index 937342fdc5a..ce182bd070f 100644 --- a/src/plugins/mcusupport/mcusupportoptions.cpp +++ b/src/plugins/mcusupport/mcusupportoptions.cpp @@ -61,7 +61,7 @@ namespace McuSupport { namespace Internal { -static const int KIT_VERSION = 6; // Bumps up whenever details in Kit creation change +static const int KIT_VERSION = 5; // Bumps up whenever details in Kit creation change static QString packagePathFromSettings(const QString &settingsKey, QSettings::Scope scope = QSettings::UserScope, @@ -452,7 +452,7 @@ void McuSupportOptions::deletePackagesAndTargets() const QVersionNumber &McuSupportOptions::supportedQulVersion() { - static const QVersionNumber v({1, 3}); + static const QVersionNumber v({1, 2}); return v; } From af69612daf33a4f01f5b6fb1acc4978272b0cc77 Mon Sep 17 00:00:00 2001 From: Leena Miettinen Date: Thu, 25 Jun 2020 16:15:37 +0200 Subject: [PATCH 6/8] Doc: Describe moving types and symbols in Outline view Task-number: QTCREATORBUG-21993 Change-Id: I2a156549e8eb8c5f31e505edeb3ab5f741be0245 Reviewed-by: Fawzi Mohamed --- doc/qtcreator/src/howto/creator-views.qdoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/qtcreator/src/howto/creator-views.qdoc b/doc/qtcreator/src/howto/creator-views.qdoc index 0c41d7b4963..fc37da94dcf 100644 --- a/doc/qtcreator/src/howto/creator-views.qdoc +++ b/doc/qtcreator/src/howto/creator-views.qdoc @@ -305,6 +305,8 @@ The \uicontrol Outline view shows an overview of defined types and other symbols, as well as their properties and hierarchy in a source file. + You can move the code for types and symbols around in the source file + by dragging and dropping them in the outline. \list \li To see a complete list of all bindings, select From a2f282e4402896d2e1b79e6f1385c1c7e09bef31 Mon Sep 17 00:00:00 2001 From: Henning Gruendl Date: Tue, 30 Jun 2020 10:30:40 +0200 Subject: [PATCH 7/8] ADS: Fix uninitialized member Change-Id: Iffbe8aef11a705930da3c3ab22ac61ab7139b9f9 Reviewed-by: Eike Ziller --- src/libs/advanceddockingsystem/dockfocuscontroller.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp index 0895fe81c32..16450c778ce 100644 --- a/src/libs/advanceddockingsystem/dockfocuscontroller.cpp +++ b/src/libs/advanceddockingsystem/dockfocuscontroller.cpp @@ -67,7 +67,7 @@ namespace ADS #ifdef Q_OS_LINUX QPointer m_floatingWidget = nullptr; #endif - DockManager *m_dockManager; + DockManager *m_dockManager = nullptr; /** * Private data constructor From 5143e6c8ba2b131378646fdb03ac0da4d2e30b56 Mon Sep 17 00:00:00 2001 From: Knud Dollereder Date: Tue, 30 Jun 2020 12:24:55 +0200 Subject: [PATCH 8/8] Fix coverity warning: Initialize result Change-Id: I95a094ecd24e78dd452a58b0757a9ae69c81a555 Reviewed-by: Thomas Hartmann --- src/plugins/qmldesigner/components/curveeditor/detail/axis.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmldesigner/components/curveeditor/detail/axis.cpp b/src/plugins/qmldesigner/components/curveeditor/detail/axis.cpp index 3001aaf36d9..6e18e49a269 100644 --- a/src/plugins/qmldesigner/components/curveeditor/detail/axis.cpp +++ b/src/plugins/qmldesigner/components/curveeditor/detail/axis.cpp @@ -144,7 +144,7 @@ LabelingInfo optLegibility(int k, double lmin, double lstep) Axis Axis::compute(double dmin, double dmax, double height, double pt) { - Axis result; + Axis result = {0.0, 0.0, 0.0}; auto score = [](double a, double b, double c, double d) { return a * 0.2 + b * 0.25 + c * 0.5 + d * 0.05;