From 6db7426d5eecd889a7d029fe9f540d2332e81671 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Fri, 8 Apr 2011 11:14:11 +0200 Subject: [PATCH] Fix warning about signed/unsigned comparison Use int instead of unsigned and do some code cosmetics while at it. --- src/libs/utils/submiteditorwidget.cpp | 10 +++++----- src/libs/utils/submiteditorwidget.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libs/utils/submiteditorwidget.cpp b/src/libs/utils/submiteditorwidget.cpp index 31334a3b2ec..e9c189a47c4 100644 --- a/src/libs/utils/submiteditorwidget.cpp +++ b/src/libs/utils/submiteditorwidget.cpp @@ -518,7 +518,7 @@ void SubmitEditorWidget::updateDiffAction() void SubmitEditorWidget::updateCheckAllComboBox() { m_d->m_ignoreChange = true; - unsigned checkedCount = checkedFilesCount(); + int checkedCount = checkedFilesCount(); if (checkedCount == 0) m_d->m_ui.checkAllCheckBox->setCheckState(Qt::Unchecked); else if (checkedCount == m_d->m_ui.fileView->model()->rowCount()) @@ -536,14 +536,14 @@ bool SubmitEditorWidget::hasSelection() const return false; } -unsigned SubmitEditorWidget::checkedFilesCount() const +int SubmitEditorWidget::checkedFilesCount() const { - unsigned checkedCount = 0; + int checkedCount = 0; if (const QAbstractItemModel *model = m_d->m_ui.fileView->model()) { const int count = model->rowCount(); - for (int i = 0; i < count; i++) + for (int i = 0; i < count; ++i) if (listModelChecked(model, i, checkableColumn)) - checkedCount++; + ++checkedCount; } return checkedCount; } diff --git a/src/libs/utils/submiteditorwidget.h b/src/libs/utils/submiteditorwidget.h index 69fc63d8c24..551856782e9 100644 --- a/src/libs/utils/submiteditorwidget.h +++ b/src/libs/utils/submiteditorwidget.h @@ -145,7 +145,7 @@ private slots: private: bool hasSelection() const; - unsigned checkedFilesCount() const; + int checkedFilesCount() const; SubmitEditorWidgetPrivate *m_d; };