feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LinuxDeviceTester: Avoid non-trivial global variables

Browse Source 
Change-Id: I1c3cf646ecbd6619f7c5a6eb117a0aca43d78534
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-11-24 18:17:15 +01:00
parent b34fc8a420
commit 6dc1a1e98f
1 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/remotelinux/linuxdevicetester.cpp
View File

@@ -49,7 +49,11 @@ public:
QList<TaskItem> m_extraTests;
};
const QStringList s_commandsToTest = {"base64",
static const char s_echoContents[] = "Hello Remote World!";
QStringList GenericLinuxDeviceTesterPrivate::commandsToTest() const
{
static const QStringList s_commandsToTest = {"base64",
"cat",
"chmod",
"cp",
@@ -78,13 +82,9 @@ const QStringList s_commandsToTest = {"base64",
"trap",
"touch",
"which"};
// other possible commands (checked for qnx):
// "awk", "grep", "netstat", "print", "pidin", "sleep", "uname"
// other possible commands (checked for qnx):
// "awk", "grep", "netstat", "print", "pidin", "sleep", "uname"
static const char s_echoContents[] = "Hello Remote World!";
QStringList GenericLinuxDeviceTesterPrivate::commandsToTest() const
{
QStringList commands = s_commandsToTest + m_extraCommands;
commands.removeDuplicates();
Utils::sort(commands);