From 6dc2da9413618199122495916e3a86a09943a4da Mon Sep 17 00:00:00 2001
From: Ivan Donchevskii <ivan.donchevskii@qt.io>
Date: Mon, 5 Nov 2018 10:14:10 +0100
Subject: [PATCH] ProjectExplorer: Parse macros when clang-cl exits with
 non-zero code

clang-cl still provides the list of macros even if it reports
some option being not supported. Try to parse the output
even in such cases.

Change-Id: I4fa070c7c465166fdf70c03944b2713478acba13
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
---
 src/plugins/projectexplorer/msvctoolchain.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/plugins/projectexplorer/msvctoolchain.cpp b/src/plugins/projectexplorer/msvctoolchain.cpp
index 4707375ab29..fb87cfb2032 100644
--- a/src/plugins/projectexplorer/msvctoolchain.cpp
+++ b/src/plugins/projectexplorer/msvctoolchain.cpp
@@ -1127,7 +1127,8 @@ Macros ClangClToolChain::msvcPredefinedMacros(const QStringList cxxflags,
                                                                  arguments);
     if (response.result != Utils::SynchronousProcessResponse::Finished ||
             response.exitCode != 0) {
-        return {};
+        // Show the warning but still parse the output.
+        QTC_CHECK(false && "clang-cl exited with non-zero code.");
     }
 
     return Macro::toMacros(response.allRawOutput());