feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Add override to IDocument hierarchy

Browse Source 
Change-Id: I6884f59fe0f06e380254c1f8076dd561d9df4ee3
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Eike Ziller
2015-06-04 15:54:10 +02:00
parent 277495e8cb
commit 6dd0e79d09
28 changed files with 159 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/bineditor/bineditorplugin.cpp
View File

@@ -239,7 +239,7 @@ public:
this, SLOT(provideNewRange(quint64)));
}
bool setContents(const QByteArray &contents)
bool setContents(const QByteArray &contents) override
{
if (!contents.isEmpty())
return false;
@@ -247,13 +247,13 @@ public:
return true;
}
ReloadBehavior reloadBehavior(ChangeTrigger state, ChangeType type) const
ReloadBehavior reloadBehavior(ChangeTrigger state, ChangeType type) const override
{
Q_UNUSED(state)
return type == TypeRemoved ? BehaviorSilent : BehaviorAsk;
}
bool save(QString *errorString, const QString &fn, bool autoSave)
bool save(QString *errorString, const QString &fn, bool autoSave) override
{
QTC_ASSERT(!autoSave, return true); // bineditor does not support autosave - it would be a bit expensive
const FileName fileNameToUse = fn.isEmpty() ? filePath() : FileName::fromString(fn);
@@ -265,7 +265,8 @@ public:
}
}
OpenResult open(QString *errorString, const QString &fileName, const QString &realFileName)
OpenResult open(QString *errorString, const QString &fileName,
const QString &realFileName) override
{
QTC_CHECK(fileName == realFileName); // The bineditor can do no autosaving
return openImpl(errorString, fileName);
@@ -338,23 +339,26 @@ private slots:
public:
QString defaultPath() const { return QString(); }
QString defaultPath() const override { return QString(); }
QString suggestedFileName() const { return QString(); }
QString suggestedFileName() const override { return QString(); }
bool isModified() const { return isTemporary()/*e.g. memory view*/ ? false
: m_widget->isModified(); }
bool isModified() const override
{
return isTemporary()/*e.g. memory view*/ ? false
: m_widget->isModified();
}
bool isFileReadOnly() const {
bool isFileReadOnly() const override {
const FileName fn = filePath();
if (fn.isEmpty())
return false;
return !fn.toFileInfo().isWritable();
}
bool isSaveAsAllowed() const { return true; }
bool isSaveAsAllowed() const override { return true; }
bool reload(QString *errorString, ReloadFlag flag, ChangeType type) {
bool reload(QString *errorString, ReloadFlag flag, ChangeType type) override {
if (flag == FlagIgnore)
return true;
if (type == TypePermissions) {