feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CodeAssist: Move base position to interface.

Browse Source 
Every proposal needs to have a base postion.
Move it to the base class to reduce duplicated code.

Change-Id: I0b1b8282dfe955d251646661f755bf9f585fbad1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2016-03-14 13:21:55 +01:00
parent 8d2858d8fe
commit 6e4a719738
6 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/texteditor/codeassist/genericproposal.cpp
View File

@@ -30,12 +30,12 @@
namespace TextEditor {
GenericProposal::GenericProposal(int cursorPos, GenericProposalModel *model)
: m_basePosition(cursorPos)
: IAssistProposal(cursorPos)
, m_model(model)
{}
GenericProposal::GenericProposal(int cursorPos, const QList<AssistProposalItemInterface *> &items)
: m_basePosition(cursorPos)
: IAssistProposal(cursorPos)
, m_model(new GenericProposalModel)
{
m_model->loadContent(items);
@@ -49,11 +49,6 @@ bool GenericProposal::isFragile() const
return false;
}
int GenericProposal::basePosition() const
{
return m_basePosition;
}
bool GenericProposal::isCorrective() const
{
return false;