TargetSetupWidget: Do not always pre-expand selected kits

Does not add much value (anymore), except in the import case.
Expanded targets take away a lot of space, pushing other targets
or potential kits out of the visible area

Change-Id: Iff0c46643b0fccef7e272a036d0c9c3a099ccc1f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Alessandro Portale
2014-03-18 17:45:11 +01:00
parent 41d3f0f2f2
commit 6e6599e0b0
3 changed files with 7 additions and 2 deletions

View File

@@ -458,6 +458,7 @@ void TargetSetupPage::import(const Utils::FileName &path, bool silent)
widget->addBuildInfo(info, true); widget->addBuildInfo(info, true);
widget->setKitSelected(true); widget->setKitSelected(true);
widget->expandWidget();
} }
emit completeChanged(); emit completeChanged();
} }

View File

@@ -148,8 +148,6 @@ void TargetSetupWidget::setKitSelected(bool b)
m_detailsWidget->setChecked(b); m_detailsWidget->setChecked(b);
m_detailsWidget->widget()->setEnabled(b); m_detailsWidget->widget()->setEnabled(b);
m_ignoreChange = false; m_ignoreChange = false;
m_detailsWidget->setState(b ? Utils::DetailsWidget::Expanded : Utils::DetailsWidget::Collapsed);
} }
void TargetSetupWidget::addBuildInfo(BuildInfo *info, bool isImport) void TargetSetupWidget::addBuildInfo(BuildInfo *info, bool isImport)
@@ -256,6 +254,11 @@ void TargetSetupWidget::setProjectPath(const QString &projectPath)
addBuildInfo(info, false); addBuildInfo(info, false);
} }
void TargetSetupWidget::expandWidget()
{
m_detailsWidget->setState(Utils::DetailsWidget::Expanded);
}
void TargetSetupWidget::handleKitUpdate(Kit *k) void TargetSetupWidget::handleKitUpdate(Kit *k)
{ {
if (k != m_kit) if (k != m_kit)

View File

@@ -76,6 +76,7 @@ public:
QList<const BuildInfo *> selectedBuildInfoList() const; QList<const BuildInfo *> selectedBuildInfoList() const;
void setProjectPath(const QString &projectPath); void setProjectPath(const QString &projectPath);
void expandWidget();
signals: signals:
void selectedToggled() const; void selectedToggled() const;