Remove some old TODO items

Change-Id: I43c893176e5a83530f909371fc143dbb0cafd3ba
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>

src/libs/utils/fancymainwindow.cpp

@@ -64,7 +64,7 @@ struct FancyMainWindowPrivate
     FancyMainWindowPrivate();
 
     bool m_locked;
-    bool m_handleDockVisibilityChanges; //todo
+    bool m_handleDockVisibilityChanges;
 
     QAction m_menuSeparator1;
     QAction m_toggleLockedAction;

src/plugins/bineditor/bineditorplugin.cpp

@@ -375,8 +375,8 @@ public:
     bool duplicateSupported() const { return false; }
     IEditor *duplicate(QWidget * /* parent */) { return 0; }
 
-    QByteArray saveState() const { return QByteArray(); } // TODO
-    bool restoreState(const QByteArray & /* state */) { return false; } // TODO
+    QByteArray saveState() const { return QByteArray(); } // not supported
+    bool restoreState(const QByteArray & /* state */) { return false; }  // not supported
 
     QWidget *toolBar() { return m_toolBar; }
 

src/plugins/coreplugin/editormanager/editormanager.cpp

@@ -1588,7 +1588,7 @@ bool EditorManager::saveDocumentAs(IDocument *documentParam)
     const bool success = DocumentManager::saveDocument(document, absoluteFilePath);
     document->checkPermissions();
 
-    // @todo: There is an issue to be treated here. The new file might be of a different mime
+    // TODO: There is an issue to be treated here. The new file might be of a different mime
     // type than the original and thus require a different editor. An alternative strategy
     // would be to close the current editor and open a new appropriate one, but this is not
     // a good way out either (also the undo stack would be lost). Perhaps the best is to

src/plugins/coreplugin/editormanager/editorview.cpp

@@ -264,7 +264,7 @@ void EditorView::setCurrentEditor(IEditor *editor)
         || m_container->indexOf(editor->widget()) == -1) {
         m_toolBar->updateEditorStatus(0);
         m_infoBarDisplay->setInfoBar(0);
-        // ### TODO the combo box m_editorList should show an empty item
+        QTC_CHECK(m_container->count() == 0);
         return;
     }
 

src/plugins/coreplugin/progressmanager/progressbar.h

@@ -51,7 +51,6 @@ public:
 
     QString title() const;
     void setTitle(const QString &title);
-    // TODO rename setError
     void setError(bool on);
     bool hasError() const;
     QSize sizeHint() const;

src/plugins/coreplugin/rightpane.cpp

@@ -182,7 +182,7 @@ void RightPaneWidget::readSettings(QSettings *settings)
     if (settings->contains(QLatin1String("RightPane/Visible"))) {
         setShown(settings->value(QLatin1String("RightPane/Visible")).toBool());
     } else {
-        setShown(false); //TODO set to false
+        setShown(false);
     }
 
     if (settings->contains(QLatin1String("RightPane/Width"))) {

src/plugins/find/searchresulttreemodel.cpp

@@ -273,13 +273,6 @@ QVariant SearchResultTreeModel::data(const SearchResultTreeItem *row, int role)
     case ItemDataRoles::IsGeneratedRole:
         result = row->isGenerated();
         break;
-// TODO this looks stupid in case of symbol tree, is it necessary?
-//    case Qt::BackgroundRole:
-//        if (row->parent() && row->parent()->parent())
-//            result = QVariant();
-//        else
-//            result = QApplication::palette().base().color().darker(105);
-//        break;
     default:
         result = QVariant();
         break;