diff --git a/src/libs/utils/filepath.cpp b/src/libs/utils/filepath.cpp index 103804b0b0c..408b41e2e3c 100644 --- a/src/libs/utils/filepath.cpp +++ b/src/libs/utils/filepath.cpp @@ -329,8 +329,7 @@ QString FileUtils::qmakeFriendlyName(const QString &name) bool FileUtils::makeWritable(const FilePath &path) { - const QString filePath = path.toString(); - return QFile::setPermissions(filePath, QFile::permissions(filePath) | QFile::WriteUser); + return path.setPermissions(path.permissions() | QFile::WriteUser); } // makes sure that capitalization of directories is canonical on Windows and OS X. diff --git a/src/plugins/coreplugin/dialogs/filepropertiesdialog.cpp b/src/plugins/coreplugin/dialogs/filepropertiesdialog.cpp index 7c69a8ad549..63b3bbde31d 100644 --- a/src/plugins/coreplugin/dialogs/filepropertiesdialog.cpp +++ b/src/plugins/coreplugin/dialogs/filepropertiesdialog.cpp @@ -185,7 +185,7 @@ void FilePropertiesDialog::setPermission(QFile::Permissions newPermissions, bool else permissions &= ~newPermissions; - if (!QFile::setPermissions(m_filePath.toString(), permissions)) + if (!m_filePath.setPermissions(permissions)) qWarning() << "Cannot change permissions for file" << m_filePath; }); diff --git a/src/plugins/cpptools/cpptoolstestcase.cpp b/src/plugins/cpptools/cpptoolstestcase.cpp index 9f024619581..fca2d11eed9 100644 --- a/src/plugins/cpptools/cpptoolstestcase.cpp +++ b/src/plugins/cpptools/cpptoolstestcase.cpp @@ -52,17 +52,20 @@ using namespace ProjectExplorer; using namespace Utils; +namespace CppTools { +namespace Tests { + static bool closeEditorsWithoutGarbageCollectorInvocation(const QList &editors) { - CppTools::CppModelManager::instance()->enableGarbageCollector(false); + CppModelManager::instance()->enableGarbageCollector(false); const bool closeEditorsSucceeded = Core::EditorManager::closeEditors(editors, false); - CppTools::CppModelManager::instance()->enableGarbageCollector(true); + CppModelManager::instance()->enableGarbageCollector(true); return closeEditorsSucceeded; } static bool snapshotContains(const CPlusPlus::Snapshot &snapshot, const QSet &filePaths) { - foreach (const QString &filePath, filePaths) { + for (const QString &filePath : filePaths) { if (!snapshot.contains(filePath)) { qWarning() << "Missing file in snapshot:" << qPrintable(filePath); return false; @@ -71,9 +74,6 @@ static bool snapshotContains(const CPlusPlus::Snapshot &snapshot, const QSet TestCase::waitForFilesInGlobalSnapshot(const QSt t.start(); QList result; - foreach (const QString &filePath, filePaths) { + for (const QString &filePath : filePaths) { forever { if (CPlusPlus::Document::Ptr document = globalSnapshot().document(filePath)) { result.append(document); @@ -333,8 +333,7 @@ static bool copyRecursively(const QString &sourceDirPath, // Copied files from Qt resources are read-only. Make them writable // so that their parent directory can be removed without warnings. - QFile file(targetPath.toString()); - return file.setPermissions(file.permissions() | QFile::WriteUser); + return targetPath.setPermissions(targetPath.permissions() | QFile::WriteUser); }; return Utils::FileUtils::copyRecursively(Utils::FilePath::fromString(sourceDirPath), diff --git a/src/tools/sdktool/operation.cpp b/src/tools/sdktool/operation.cpp index a31e6ce271e..44af491b867 100644 --- a/src/tools/sdktool/operation.cpp +++ b/src/tools/sdktool/operation.cpp @@ -123,8 +123,7 @@ bool Operation::save(const QVariantMap &map, const QString &file) const << "." << std::endl; return false; } - if (!QFile::setPermissions(path.toString(), - QFile::ReadOwner | QFile::WriteOwner + if (!path.setPermissions(QFile::ReadOwner | QFile::WriteOwner | QFile::ReadGroup | QFile::ReadOther)) { std::cerr << "Error: Could not set permissions for " << qPrintable(path.toString()) << "." << std::endl;