From 6ecb6f1e1cd45219d9cfb243bb0a1712de0af9e6 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Thu, 29 Aug 2024 16:18:26 +0200
Subject: [PATCH] QmlDesigner: Fix endless loop

Change-Id: If2f219bb1fd5d2173f4fd38c4854f6fbf1f32d93
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 .../qmldesigner/components/navigator/navigatorview.cpp        | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/plugins/qmldesigner/components/navigator/navigatorview.cpp b/src/plugins/qmldesigner/components/navigator/navigatorview.cpp
index fadccd41f37..afb5ad6286f 100644
--- a/src/plugins/qmldesigner/components/navigator/navigatorview.cpp
+++ b/src/plugins/qmldesigner/components/navigator/navigatorview.cpp
@@ -693,12 +693,14 @@ void NavigatorView::updateItemSelection()
                 itemSelection.select(beginIndex, endIndex);
         } else {
             // if the node index is invalid expand ancestors manually if they are valid.
-            while (ModelNode parentNode = node.parentProperty().parentModelNode()) {
+            ModelNode parentNode = node.parentProperty().parentModelNode();
+            while (parentNode) {
                 QModelIndex parentIndex = indexForModelNode(parentNode);
                 if (parentIndex.isValid())
                     treeWidget()->expand(parentIndex);
                 else
                     break;
+                parentNode = parentNode.parentProperty().parentModelNode();
             }
          }
     }