From 6ecde4cdf0b60a249cea528023058dcf4c2767bc Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 9 Mar 2015 12:15:43 +0100 Subject: [PATCH] MimeDatabase: Fix leak on invalid magic Introduced by 673be1a3f8d28474d830762e46c7157a54ef3c39 Change-Id: Ia937b3607d6a709b86185f428a6e3ff1202e0869 Reviewed-by: Daniel Teske --- src/libs/utils/mimetypes/mimetypeparser.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libs/utils/mimetypes/mimetypeparser.cpp b/src/libs/utils/mimetypes/mimetypeparser.cpp index c1db64fb5c4..92e69f3bf5b 100644 --- a/src/libs/utils/mimetypes/mimetypeparser.cpp +++ b/src/libs/utils/mimetypes/mimetypeparser.cpp @@ -188,8 +188,10 @@ static bool createMagicMatchRule(const QXmlStreamAttributes &atts, MimeMagicRule *tempRule = new MimeMagicRule(magicType, value.toUtf8(), startPos, endPos, mask.toLatin1(), errorMessage); - if (!tempRule->isValid()) + if (!tempRule->isValid()) { + delete tempRule; return false; + } rule = tempRule; return true;