feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: InstantBlame: Init m_cursorPositionChangedTimer in ctor

Browse Source 
Needs to be done only once, and fixes a dangling
pointer if setup() was called twice.

Change-Id: I02722daf5dffdfb2d4bb70de77436eb8d930806d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2024-01-20 18:21:52 +01:00
committed by André Hartmann
parent 7493b3a630
commit 6f665c26a5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/git/instantblame.cpp
View File

@@ -104,14 +104,14 @@ QString BlameMark::toolTipText(const CommitInfo &info) const
InstantBlame::InstantBlame() InstantBlame::InstantBlame()
{ {
m_codec = gitClient().defaultCommitEncoding(); m_codec = gitClient().defaultCommitEncoding();
m_cursorPositionChangedTimer = new QTimer(this);
m_cursorPositionChangedTimer->setSingleShot(true);
connect(m_cursorPositionChangedTimer, &QTimer::timeout, this, &InstantBlame::perform);
} }
void InstantBlame::setup() void InstantBlame::setup()
{ {
qCDebug(log) << "Setup"; qCDebug(log) << "Setup";
m_cursorPositionChangedTimer = new QTimer(this);
m_cursorPositionChangedTimer->setSingleShot(true);
connect(m_cursorPositionChangedTimer, &QTimer::timeout, this, &InstantBlame::perform);
auto setupBlameForEditor = [this](Core::IEditor *editor) { auto setupBlameForEditor = [this](Core::IEditor *editor) {
if (!editor) { if (!editor) {