From 6f6dbe23b8d5dd31d5bc7a28058c48a789129160 Mon Sep 17 00:00:00 2001 From: Robert Loehning Date: Wed, 21 May 2014 20:01:13 +0200 Subject: [PATCH] Squish: Optimization in checkLastBuild() Change-Id: Id706efcf25e39d55a80ebfcd2ed0212c7f1a2324 Reviewed-by: Christian Stenger --- tests/system/shared/build_utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/system/shared/build_utils.py b/tests/system/shared/build_utils.py index 98ed0bdd9ac..7811915546c 100644 --- a/tests/system/shared/build_utils.py +++ b/tests/system/shared/build_utils.py @@ -43,8 +43,9 @@ def checkLastBuild(expectedToFail=False, createTasksFileOnError=True): ensureChecked(":Qt Creator_Issues_Core::Internal::OutputPaneToggleButton") model = waitForObject(":Qt Creator.Issues_QListView").model() buildIssues = dumpBuildIssues(model) - errors = len(filter(lambda i: i[5] == "1", buildIssues)) - warnings = len(filter(lambda i: i[5] == "2", buildIssues)) + types = map(lambda i: i[5], buildIssues) + errors = types.count("1") + warnings = types.count("2") gotErrors = errors != 0 if not (gotErrors ^ expectedToFail): test.passes("Errors: %s | Warnings: %s" % (errors, warnings))