McuSupport: Inform only after actual kit creation

Previously, a message about successful kit creation was printed
for every kit without verification. So move the print to the
actual kit creation function. Issue also reported in
QTCREATORBUG-28281

Change-Id: I0e2cb463188210164a3582e7fa465a4ebb79b812
Reviewed-by: Sivert Krøvel <sivert.krovel@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/mcusupport/mcukitmanager.cpp

@@ -345,7 +345,15 @@ Kit *newKit(const McuTarget *mcuTarget, const McuPackagePtr &qtForMCUsSdk)
         k->fix();
     };
 
-    return KitManager::registerKit(init);
+    Kit *kit = KitManager::registerKit(init);
+    if (kit) {
+        printMessage(Tr::tr("Kit for %1 created.").arg(generateKitNameFromTarget(mcuTarget)), false);
+    } else {
+        printMessage(Tr::tr("Error registering Kit for %1.")
+                         .arg(generateKitNameFromTarget(mcuTarget)),
+                     true);
+    }
+    return kit;
 }
 
 // Kit Information

src/plugins/mcusupport/mcusupportsdk.cpp

@@ -815,11 +815,6 @@ McuSdkRepository targetsAndPackages(const McuPackagePtr &qtForMCUsPackage,
                < McuKitManager::generateKitNameFromTarget(rhs.get());
     });
 
-    for (const auto &target : repo.mcuTargets) {
-        printMessage(McuTarget::tr("Kit for %1 created.")
-                         .arg(McuKitManager::generateKitNameFromTarget(target.get())),
-                     false);
-    }
     return repo;
 }