feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Simplify AndroidExtraLibraryListModel::data()

Browse Source 
This was triggered by a warning on a empty expression statement,
but it turns out that QDir::cleanPath calls can be avoided, too.

Change-Id: I930cbb1272294f57794c29e0cd48e3c0ba8c6fdf
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
This commit is contained in:
hjk
2019-08-02 15:03:01 +02:00
parent d272a64eab
commit 6f949ebf18
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/android/androidextralibrarylistmodel.cpp
View File

@@ -76,11 +76,9 @@ int AndroidExtraLibraryListModel::columnCount(const QModelIndex &) const
QVariant AndroidExtraLibraryListModel::data(const QModelIndex &index, int role) const QVariant AndroidExtraLibraryListModel::data(const QModelIndex &index, int role) const
{ {
Q_ASSERT(index.row() >= 0 && index.row() < m_entries.size()); Q_ASSERT(index.row() >= 0 && index.row() < m_entries.size());
const QString &entry = QDir::cleanPath(m_entries.at(index.row())); if (role == Qt::DisplayRole)
switch (role) { return QDir::cleanPath(m_entries.at(index.row()));
case Qt::DisplayRole: return entry; return {};
default: return QVariant();
};
} }
void AndroidExtraLibraryListModel::updateModel() void AndroidExtraLibraryListModel::updateModel()