From 6fcb853b193683703e303cf8cb293899d10ba6b7 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Thu, 21 Dec 2023 15:27:40 +0100 Subject: [PATCH] QmlDesigner: Add QTC_ASSERTS This can prevent crashes, but is unexpected behaivour. Change-Id: Ie0944652c230a25e18f5d740cf134bc3ef7e2f2f Reviewed-by: Qt CI Patch Build Bot Reviewed-by: Thomas Hartmann --- .../qmldesigner/designercore/model/texttomodelmerger.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp b/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp index 889f8471978..037259e87e4 100644 --- a/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp +++ b/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp @@ -388,6 +388,7 @@ bool smartVeryFuzzyCompare(const QVariant &value1, const QVariant &value2) void removeModelNode(const QmlDesigner::ModelNode &modelNode) { + QTC_ASSERT(modelNode.isValid(), return ); modelNode.model()->removeModelNodes({modelNode}, QmlDesigner::BypassModelResourceManagement::Yes); } @@ -400,6 +401,7 @@ bool smartColorCompare(const QVariant &value1, const QVariant &value2) void removeProperty(const QmlDesigner::AbstractProperty &modelProperty) { + QTC_ASSERT(modelProperty.isValid(), return ); modelProperty.model()->removeProperties({modelProperty}, QmlDesigner::BypassModelResourceManagement::Yes); }