feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Remove Q_PROPERTY definitions

Browse Source 
The initial intention was to make these widgets usable from Designer.

We don't expect a lot of new uses in this direction, and clazy
seems to warn about not-so-complete Q_PROPERTY definitions:

Link https://github.com/KDE/clazy/blob/master/docs/checks/README-qproperty-without-notify.md

Change-Id: I4a2e9ff6ec7ecfd989196801c789533b4c44e8af
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2022-09-27 11:16:17 +02:00
parent 957a26d379
commit 6ff6fe3b0e
4 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/vcsbase/submiteditorwidget.h
View File

@@ -22,12 +22,6 @@ class SubmitFileModel;
class VCSBASE_EXPORT SubmitEditorWidget : public QWidget class VCSBASE_EXPORT SubmitEditorWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
Q_PROPERTY(QString descriptionText READ descriptionText WRITE setDescriptionText DESIGNABLE true)
Q_PROPERTY(QAbstractItemView::SelectionMode fileListSelectionMode READ fileListSelectionMode WRITE setFileListSelectionMode DESIGNABLE true)
Q_PROPERTY(bool lineWrap READ lineWrap WRITE setLineWrap DESIGNABLE true)
Q_PROPERTY(int lineWrapWidth READ lineWrapWidth WRITE setLineWrapWidth DESIGNABLE true)
Q_PROPERTY(bool descriptionMandatory READ isDescriptionMandatory WRITE setDescriptionMandatory DESIGNABLE false)
Q_PROPERTY(bool emptyFileListEnabled READ isEmptyFileListEnabled WRITE setEmptyFileListEnabled DESIGNABLE true)
public: public:
SubmitEditorWidget(); SubmitEditorWidget();

3
src/plugins/vcsbase/submitfieldwidget.h
View File

@@ -18,9 +18,6 @@ struct SubmitFieldWidgetPrivate;
class VCSBASE_EXPORT SubmitFieldWidget : public QWidget class VCSBASE_EXPORT SubmitFieldWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
Q_PROPERTY(QStringList fields READ fields WRITE setFields DESIGNABLE true)
Q_PROPERTY(bool hasBrowseButton READ hasBrowseButton WRITE setHasBrowseButton DESIGNABLE true)
Q_PROPERTY(bool allowDuplicateFields READ allowDuplicateFields WRITE setAllowDuplicateFields DESIGNABLE true)
public: public:
explicit SubmitFieldWidget(QWidget *parent = nullptr); explicit SubmitFieldWidget(QWidget *parent = nullptr);

5
src/plugins/vcsbase/vcsbaseeditor.h
View File

@@ -110,11 +110,6 @@ public:
class VCSBASE_EXPORT VcsBaseEditorWidget : public TextEditor::TextEditorWidget class VCSBASE_EXPORT VcsBaseEditorWidget : public TextEditor::TextEditorWidget
{ {
Q_PROPERTY(QString source READ source WRITE setSource)
Q_PROPERTY(Utils::FilePath workingDirectory READ workingDirectory WRITE setWorkingDirectory)
Q_PROPERTY(QTextCodec *codec READ codec WRITE setCodec)
Q_PROPERTY(QString annotateRevisionTextFormat READ annotateRevisionTextFormat WRITE setAnnotateRevisionTextFormat)
Q_PROPERTY(bool isFileLogAnnotateEnabled READ isFileLogAnnotateEnabled WRITE setFileLogAnnotateEnabled)
Q_OBJECT Q_OBJECT
protected: protected:

4
src/plugins/vcsbase/vcsbasesubmiteditor.h
View File

@@ -36,10 +36,6 @@ public:
class VCSBASE_EXPORT VcsBaseSubmitEditor : public Core::IEditor class VCSBASE_EXPORT VcsBaseSubmitEditor : public Core::IEditor
{ {
Q_OBJECT Q_OBJECT
Q_PROPERTY(QAbstractItemView::SelectionMode fileListSelectionMode READ fileListSelectionMode WRITE setFileListSelectionMode DESIGNABLE true)
Q_PROPERTY(bool lineWrap READ lineWrap WRITE setLineWrap DESIGNABLE true)
Q_PROPERTY(int lineWrapWidth READ lineWrapWidth WRITE setLineWrapWidth DESIGNABLE true)
Q_PROPERTY(bool emptyFileListEnabled READ isEmptyFileListEnabled WRITE setEmptyFileListEnabled DESIGNABLE true)
protected: protected:
explicit VcsBaseSubmitEditor(SubmitEditorWidget *editorWidget); explicit VcsBaseSubmitEditor(SubmitEditorWidget *editorWidget);