feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Hide hint label in dialogs that cannot use override ports

Browse Source 
Change-Id: I4de5b8bca1084f89987c3656e7b46a62a0905051
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2019-03-22 14:58:28 +01:00
parent 4e67ba7f09
commit 70199aa4f4
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/debugger/debuggerdialogs.cpp
View File

@@ -73,6 +73,7 @@ class StartApplicationDialogPrivate
public: public:
KitChooser *kitChooser; KitChooser *kitChooser;
QLabel *serverPortLabel; QLabel *serverPortLabel;
QLabel *channelOverrideHintLabel;
QLabel *channelOverrideLabel; QLabel *channelOverrideLabel;
QLineEdit *channelOverrideEdit; QLineEdit *channelOverrideEdit;
QSpinBox *serverPortSpinBox; QSpinBox *serverPortSpinBox;
@@ -237,6 +238,12 @@ StartApplicationDialog::StartApplicationDialog(QWidget *parent)
d->serverPortSpinBox = new QSpinBox(this); d->serverPortSpinBox = new QSpinBox(this);
d->serverPortSpinBox->setRange(1, 65535); d->serverPortSpinBox->setRange(1, 65535);
d->channelOverrideHintLabel =
new QLabel(tr("Normally, the running server is identified by the IP of the "
"device in the kit and the server port selected above.\n"
"You can choose another communication channel here, such as "
"a serial line or custom ip:port."));
d->channelOverrideLabel = new QLabel(tr("Override server channel:"), this); d->channelOverrideLabel = new QLabel(tr("Override server channel:"), this);
d->channelOverrideEdit = new QLineEdit(this); d->channelOverrideEdit = new QLineEdit(this);
//: "For example, /dev/ttyS0, COM1, 127.0.0.1:1234" //: "For example, /dev/ttyS0, COM1, 127.0.0.1:1234"
@@ -304,10 +311,7 @@ StartApplicationDialog::StartApplicationDialog(QWidget *parent)
formLayout->addRow(tr("Break at \"&main\":"), d->breakAtMainCheckBox); formLayout->addRow(tr("Break at \"&main\":"), d->breakAtMainCheckBox);
formLayout->addRow(d->serverStartScriptLabel, d->serverStartScriptPathChooser); formLayout->addRow(d->serverStartScriptLabel, d->serverStartScriptPathChooser);
formLayout->addRow(tr("Debug &information:"), d->debuginfoPathChooser); formLayout->addRow(tr("Debug &information:"), d->debuginfoPathChooser);
formLayout->addRow(new QLabel(tr("Normally, the running server is identified by the IP of the " formLayout->addRow(d->channelOverrideHintLabel);
"device in the kit and the server port selected above.\n"
"You can choose another communication channel here, such as "
"a serial line or custom ip:port.")));
formLayout->addRow(d->channelOverrideLabel, d->channelOverrideEdit); formLayout->addRow(d->channelOverrideLabel, d->channelOverrideEdit);
formLayout->addRow(line2); formLayout->addRow(line2);
formLayout->addRow(tr("&Recent:"), d->historyComboBox); formLayout->addRow(tr("&Recent:"), d->historyComboBox);
@@ -396,6 +400,7 @@ void StartApplicationDialog::run(bool attachRemote)
dialog.d->serverStartScriptLabel->setVisible(false); dialog.d->serverStartScriptLabel->setVisible(false);
dialog.d->serverPortSpinBox->setVisible(false); dialog.d->serverPortSpinBox->setVisible(false);
dialog.d->serverPortLabel->setVisible(false); dialog.d->serverPortLabel->setVisible(false);
dialog.d->channelOverrideHintLabel->setVisible(false);
dialog.d->channelOverrideLabel->setVisible(false); dialog.d->channelOverrideLabel->setVisible(false);
dialog.d->channelOverrideEdit->setVisible(false); dialog.d->channelOverrideEdit->setVisible(false);
} }