From 70369aca13e22ecb31dd31ffd6b9b2eb5537574e Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 6 Mar 2023 09:10:34 +0200 Subject: [PATCH] Android: Remove unreachable return Reported by Coverity. Change-Id: Id1b67f0adae3ff0c9157428726778c8c3b2a03a7 Reviewed-by: Alessandro Portale --- src/plugins/android/androidmanager.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/plugins/android/androidmanager.cpp b/src/plugins/android/androidmanager.cpp index e4d47be7337..a15da300483 100644 --- a/src/plugins/android/androidmanager.cpp +++ b/src/plugins/android/androidmanager.cpp @@ -278,18 +278,15 @@ QString packageSubPath(PackageFormat format, BuildConfiguration::BuildType build const bool deb = (buildType == BuildConfiguration::Debug); if (format == Apk) { - if (deb) + if (deb) { return sig ? packageSubPath(Apk, BuildConfiguration::Release, true) // Intentional : QLatin1String("apk/debug/android-build-debug.apk"); - else - return QLatin1String(sig ? "apk/release/android-build-release-signed.apk" - : "apk/release/android-build-release-unsigned.apk"); - } else { - return QLatin1String(deb ? "bundle/debug/android-build-debug.aab" - : "bundle/release/android-build-release.aab"); + } + return QLatin1String(sig ? "apk/release/android-build-release-signed.apk" + : "apk/release/android-build-release-unsigned.apk"); } - - return {}; + return QLatin1String(deb ? "bundle/debug/android-build-debug.aab" + : "bundle/release/android-build-release.aab"); } FilePath AndroidManager::packagePath(const Target *target)