From 70394b29af61b4a4eeb54dbb83d7c0d9c0bab628 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Fri, 29 Apr 2016 11:15:14 +0200 Subject: [PATCH] AutoTest: Make delegate independent from sub-classes... ...of TestTreeItem. Change-Id: Ieacaeff64dced5e2a4dd3bd3a853cfb1081f5146 Reviewed-by: David Schulz --- src/plugins/autotest/testtreeitem.cpp | 9 +++++---- src/plugins/autotest/testtreeitem.h | 2 +- src/plugins/autotest/testtreeitemdelegate.cpp | 5 ++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/autotest/testtreeitem.cpp b/src/plugins/autotest/testtreeitem.cpp index a692b7023a4..83196e66029 100644 --- a/src/plugins/autotest/testtreeitem.cpp +++ b/src/plugins/autotest/testtreeitem.cpp @@ -88,6 +88,8 @@ QVariant TestTreeItem::data(int /*column*/, int role) const return false; case TypeRole: return m_type; + case EnabledRole: + return true; } return QVariant(); } @@ -869,8 +871,7 @@ QVariant GoogleTestTreeItem::data(int column, int role) const if (type() == TestTreeItem::Root) break; - const QString &displayName = (m_state & GoogleTestTreeItem::Disabled) - ? name().mid(9) : name(); + const QString &displayName = (m_state & Disabled) ? name().mid(9) : name(); return QVariant(displayName + nameSuffix()); } case Qt::CheckStateRole: @@ -883,8 +884,8 @@ QVariant GoogleTestTreeItem::data(int column, int role) const } case ItalicRole: return false; - case StateRole: - return (int)m_state; + case EnabledRole: + return !(m_state & Disabled); default: break; } diff --git a/src/plugins/autotest/testtreeitem.h b/src/plugins/autotest/testtreeitem.h index 70a2fbc4381..d6e444602f2 100644 --- a/src/plugins/autotest/testtreeitem.h +++ b/src/plugins/autotest/testtreeitem.h @@ -36,7 +36,7 @@ namespace { LinkRole = Qt::UserRole + 2, // can be removed if AnnotationRole comes back ItalicRole, // used only inside the delegate TypeRole, - StateRole + EnabledRole }; } diff --git a/src/plugins/autotest/testtreeitemdelegate.cpp b/src/plugins/autotest/testtreeitemdelegate.cpp index 9771385c8a4..e7151632e1d 100644 --- a/src/plugins/autotest/testtreeitemdelegate.cpp +++ b/src/plugins/autotest/testtreeitemdelegate.cpp @@ -25,7 +25,6 @@ #include "testtreeitem.h" #include "testtreeitemdelegate.h" -#include "testtreemodel.h" #include @@ -70,8 +69,8 @@ void TestTreeItemDelegate::paint(QPainter *painter, const QStyleOptionViewItem & } } - // paint disabled googletests in gray - if (index.data(StateRole).toInt() & GoogleTestTreeItem::Disabled) + // paint disabled items in gray + if (!index.data(EnabledRole).toBool()) opt.palette.setColor(QPalette::Text, QColor(0xa0, 0xa0, 0xa0)); QStyledItemDelegate::paint(painter, opt, index);