From 70466ed81191e4fb40d30b8d3078ff0247018b0c Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Thu, 6 Oct 2022 20:00:31 +0200
Subject: [PATCH] Replace foreach with ranged for loop

Change-Id: I6238651d0b6ea8b932195711d3da7442158d2456
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
---
 plugins/fossil/commiteditor.cpp             | 2 +-
 plugins/fossil/fossilclient.cpp             | 3 ++-
 plugins/fossil/fossilplugin.cpp             | 5 +++--
 plugins/fossil/wizard/fossiljsextension.cpp | 8 ++++----
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/plugins/fossil/commiteditor.cpp b/plugins/fossil/commiteditor.cpp
index ac12ae128f6..0a32e68b7ef 100644
--- a/plugins/fossil/commiteditor.cpp
+++ b/plugins/fossil/commiteditor.cpp
@@ -80,7 +80,7 @@ void CommitEditor::setFields(const QString &repositoryRoot, const BranchInfo &br
                 [](const VcsBase::VcsBaseClient::StatusItem &item)
     { return item.flags != Constants::FSTATUS_UNKNOWN; });
     for (const VcsBase::VcsBaseClient::StatusItem &item : toAdd)
-            m_fileModel->addFile(item.file, item.flags);
+        m_fileModel->addFile(item.file, item.flags);
 
     setFileModel(m_fileModel);
 }
diff --git a/plugins/fossil/fossilclient.cpp b/plugins/fossil/fossilclient.cpp
index f1cd0110f4f..5cb7bccf2a2 100644
--- a/plugins/fossil/fossilclient.cpp
+++ b/plugins/fossil/fossilclient.cpp
@@ -198,7 +198,8 @@ public:
         QStringList args;
 
         // split "-t val" => "-t" "val"
-        foreach (const QString &arg, VcsBaseEditorConfig::arguments()) {
+        const QStringList arguments = VcsBaseEditorConfig::arguments();
+        for (const QString &arg : arguments) {
             if (arg.startsWith("-t")) {
                 args << arg.split(' ');
 
diff --git a/plugins/fossil/fossilplugin.cpp b/plugins/fossil/fossilplugin.cpp
index 3bfb0f94423..2ae9a1ef256 100644
--- a/plugins/fossil/fossilplugin.cpp
+++ b/plugins/fossil/fossilplugin.cpp
@@ -853,7 +853,8 @@ bool FossilPluginPrivate::submitEditorAboutToClose()
             extraOptions << "--branch" << enquotedBranch;
         }
         // Tags
-        foreach (QString tag, commitWidget->tags()) {
+        const QStringList tags = commitWidget->tags();
+        for (const QString &tag : tags) {
             extraOptions << "--tag" << tag;
         }
 
@@ -886,7 +887,7 @@ void FossilPluginPrivate::updateActions(VcsBase::VcsBasePluginPrivate::ActionSta
     m_revertFile->setParameter(filename);
     m_statusFile->setParameter(filename);
 
-    foreach (QAction *repoAction, m_repositoryActionList)
+    for (QAction *repoAction : qAsConst(m_repositoryActionList))
         repoAction->setEnabled(repoEnabled);
 }
 
diff --git a/plugins/fossil/wizard/fossiljsextension.cpp b/plugins/fossil/wizard/fossiljsextension.cpp
index 701c55d9224..2cdf2c27952 100644
--- a/plugins/fossil/wizard/fossiljsextension.cpp
+++ b/plugins/fossil/wizard/fossiljsextension.cpp
@@ -56,10 +56,10 @@ void FossilJsExtension::parseArgOptions(const QStringList &args, QMap<QString, Q
 {
     options.clear();
 
-    foreach (const QString &arg, args) {
-        if (arg.isEmpty()) continue;
-
-        QStringList opt = arg.split('|', Qt::KeepEmptyParts);
+    for (const QString &arg : args) {
+        if (arg.isEmpty())
+            continue;
+        const QStringList opt = arg.split('|', Qt::KeepEmptyParts);
         options.insert(opt[0], opt.size() > 1 ? opt[1] : QString());
     }
 }