From 70578004cb3b30b393a27a166fa38fb66cde8337 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Mon, 13 Mar 2017 10:18:41 +0100
Subject: [PATCH] ProjectExplorer: Some code cosmetics

Silence a warning about using a pair by value instead by reference.

Also, remove an unnecessary duplicated check.

Change-Id: Idd5a01cdfcb16dad03389d2f360e0b2dbff21dc8
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
---
 src/plugins/projectexplorer/session.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/plugins/projectexplorer/session.cpp b/src/plugins/projectexplorer/session.cpp
index 87e2b95d496..3cc54c2dcc9 100644
--- a/src/plugins/projectexplorer/session.cpp
+++ b/src/plugins/projectexplorer/session.cpp
@@ -200,8 +200,6 @@ void SessionManager::updateProjectTree(Project *pro)
             break;
         }
     }
-    if (!currentPair)
-        return;
 
     if (!currentPair)
         return; // Project was already de-registered and is shutting down
@@ -675,7 +673,7 @@ Project *SessionManager::projectForNode(Node *node)
     while (rootProjectNode && rootProjectNode->parentFolderNode() != &d->m_sessionNode)
         rootProjectNode = rootProjectNode->parentFolderNode();
 
-    for (const QPair<Project *,ProjectNode*> pair : d->m_projects) {
+    for (const QPair<Project *, ProjectNode *> &pair : d->m_projects) {
         if (pair.second == rootProjectNode)
             return pair.first;
     }