From 70c44acdd88efdff3e51eede3f2ce00faf26a028 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Tue, 22 Mar 2022 10:04:04 +0100 Subject: [PATCH] QmlDesigner: Fix itemlibrary template generation Since this is likely executed in a transaction and newQmlObjectNode.setId() uses refactoring on the QML code this is not working as expected. Setting the id without any refactoring, that triggers changes of the QML code, is save to be used. Change-Id: I5d29689eff34827de9e451f433d9a4b42569a64e Reviewed-by: Miikka Heikkinen Reviewed-by: Mahmoud Badri --- src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp index d6f417407c1..f8044fd6da1 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlvisualnode.cpp @@ -335,7 +335,7 @@ QmlObjectNode QmlVisualNode::createQmlObjectNode(AbstractView *view, if (!newQmlObjectNode.isValid()) return; - newQmlObjectNode.setId(view->model()->generateNewId(itemLibraryEntry.name())); + newQmlObjectNode.modelNode().setIdWithoutRefactoring(view->model()->generateNewId(itemLibraryEntry.name())); for (const auto &propertyBindingEntry : propertyBindingList) newQmlObjectNode.modelNode().bindingProperty(propertyBindingEntry.first).setExpression(propertyBindingEntry.second);