feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Simplfy code dealing with the projects page

Browse Source 
Distinguish between pages that are target specific and project specific.
Do the magic hierarchy reduction if only one target is supported just in
the projectwindow. Treat the targets page specially.

Reviewed-By: hunger
This commit is contained in:
dt
2010-03-25 16:16:38 +01:00
parent 184fd353d2
commit 70dc75990f
14 changed files with 91 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
src/plugins/projectexplorer/targetsettingspanel.cpp
View File

@@ -47,71 +47,6 @@
using namespace ProjectExplorer;
using namespace ProjectExplorer::Internal;
///
// TargetSettingsPanelFactory
///
QString TargetSettingsPanelFactory::id() const
{
return QLatin1String(TARGETSETTINGS_PANEL_ID);
}
QString TargetSettingsPanelFactory::displayName() const
{
return QCoreApplication::translate("TargetSettingsPanelFactory", "Targets");
}
bool TargetSettingsPanelFactory::supports(Project *project)
{
Q_UNUSED(project);
return true;
}
bool TargetSettingsPanelFactory::supports(Target *target)
{
Q_UNUSED(target);
return false;
}
IPropertiesPanel *TargetSettingsPanelFactory::createPanel(Project *project)
{
return new TargetSettingsPanel(project);
}
IPropertiesPanel *TargetSettingsPanelFactory::createPanel(Target *target)
{
Q_UNUSED(target);
return 0;
}
///
// TargetSettingsPanel
///
TargetSettingsPanel::TargetSettingsPanel(Project *project) :
m_widget(new TargetSettingsPanelWidget(project))
{
}
TargetSettingsPanel::~TargetSettingsPanel()
{
delete m_widget;
}
QString TargetSettingsPanel::displayName() const
{
return QCoreApplication::translate("TargetSettingsPanel", "Targets");
}
QWidget *TargetSettingsPanel::widget() const
{
return m_widget;
}
QIcon TargetSettingsPanel::icon() const
{
return QIcon();
}
///
// TargetSettingsWidget
@@ -223,7 +158,7 @@ void TargetSettingsPanelWidget::currentTargetChanged(int targetIndex, int subInd
PanelsWidget *buildPanel(new PanelsWidget(m_centralWidget));
PanelsWidget *runPanel(new PanelsWidget(m_centralWidget));
foreach (IPanelFactory *panelFactory, ExtensionSystem::PluginManager::instance()->getObjects<IPanelFactory>()) {
foreach (ITargetPanelFactory *panelFactory, ExtensionSystem::PluginManager::instance()->getObjects<ITargetPanelFactory>()) {
if (panelFactory->id() == QLatin1String(BUILDSETTINGS_PANEL_ID)) {
IPropertiesPanel *panel = panelFactory->createPanel(target);
buildPanel->addPropertiesPanel(panel);