Vcs/Text search: Remove a few addAutoReleaseObject uses

Using a QObject parent suffices here.

Change-Id: I4dc5448511d55bf14fbd8f810e91336a49e94094
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/bazaar/bazaarplugin.cpp

@@ -157,7 +157,7 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
     auto vcsCtrl = initializeVcs<BazaarControl>(context, m_client);
     connect(m_client, &VcsBaseClient::changed, vcsCtrl, &BazaarControl::changed);
 
-    addAutoReleasedObject(new OptionsPage(vcsCtrl));
+    new OptionsPage(vcsCtrl, this);
 
     const auto describeFunc = [this](const QString &source, const QString &id) {
         m_client->view(source, id);
@@ -165,14 +165,13 @@ bool BazaarPlugin::initialize(const QStringList &arguments, QString *errorMessag
     const int editorCount = sizeof(editorParameters) / sizeof(VcsBaseEditorParameters);
     const auto widgetCreator = []() { return new BazaarEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitEditorParameters,
+    (void) new VcsSubmitEditorFactory(&submitEditorParameters,
-        []() { return new CommitEditor(&submitEditorParameters); }));
+        []() { return new CommitEditor(&submitEditorParameters); }, this);
 
     const QString prefix = QLatin1String("bzr");
-    m_commandLocator = new CommandLocator("Bazaar", prefix, prefix);
+    m_commandLocator = new CommandLocator("Bazaar", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     createMenu(context);
 

src/plugins/bazaar/optionspage.cpp

@@ -65,8 +65,8 @@ void OptionsPageWidget::setSettings(const VcsBaseClientSettings &s)
     m_ui.timeout->setValue(s.intValue(BazaarSettings::timeoutKey));
 }
 
-OptionsPage::OptionsPage(Core::IVersionControl *control) :
+OptionsPage::OptionsPage(Core::IVersionControl *control, QObject *parent) :
-    VcsClientOptionsPage(control, BazaarPlugin::instance()->client())
+    VcsClientOptionsPage(control, BazaarPlugin::instance()->client(), parent)
 {
     setId(VcsBase::Constants::VCS_ID_BAZAAR);
     setDisplayName(tr("Bazaar"));

src/plugins/bazaar/optionspage.h

@@ -54,7 +54,7 @@ class OptionsPage : public VcsBase::VcsClientOptionsPage
     Q_OBJECT
 
 public:
-    OptionsPage(Core::IVersionControl *control);
+    OptionsPage(Core::IVersionControl *control, QObject *parent);
 };
 
 } // namespace Internal

src/plugins/clearcase/clearcaseplugin.cpp

@@ -423,10 +423,10 @@ bool ClearCasePlugin::initialize(const QStringList & /*arguments */, QString *er
     connect(SessionManager::instance(), &SessionManager::startupProjectChanged,
             this, &ClearCasePlugin::projectChanged);
 
-    addAutoReleasedObject(new SettingsPage);
+    new SettingsPage(this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters,
+    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new ClearCaseSubmitEditor(&submitParameters); }));
+        []() { return new ClearCaseSubmitEditor(&submitParameters); }, this);
 
     // any editor responds to describe (when clicking a version)
     const auto describeFunc = [this](const QString &source, const QString &changeNr) {
@@ -435,13 +435,12 @@ bool ClearCasePlugin::initialize(const QStringList & /*arguments */, QString *er
     const int editorCount = sizeof(editorParameters)/sizeof(VcsBaseEditorParameters);
     const auto widgetCreator = []() { return new ClearCaseEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
     const QString description = QLatin1String("ClearCase");
     const QString prefix = QLatin1String("cc");
     // register cc prefix in Locator
-    m_commandLocator = new CommandLocator("cc", description, prefix);
+    m_commandLocator = new CommandLocator("cc", description, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     //register actions
     ActionContainer *toolsContainer = ActionManager::actionContainer(M_TOOLS);

src/plugins/clearcase/settingspage.cpp

@@ -104,7 +104,8 @@ void SettingsPageWidget::setSettings(const ClearCaseSettings &s)
     m_ui.indexOnlyVOBsEdit->setText(s.indexOnlyVOBs);
 }
 
-SettingsPage::SettingsPage()
+SettingsPage::SettingsPage(QObject *parent)
+    : VcsBaseOptionsPage(parent)
 {
     setId(ClearCase::Constants::VCS_ID_CLEARCASE);
     setDisplayName(tr("ClearCase"));

src/plugins/clearcase/settingspage.h

@@ -57,7 +57,7 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage
     Q_OBJECT
 
 public:
-    SettingsPage();
+    explicit SettingsPage(QObject *parent);
 
     QWidget *widget() override;
     void apply() override;

src/plugins/cvs/cvsplugin.cpp

@@ -204,10 +204,10 @@ bool CvsPlugin::initialize(const QStringList &arguments, QString *errorMessage)
 
     m_client = new CvsClient;
 
-    addAutoReleasedObject(new SettingsPage(versionControl()));
+    new SettingsPage(versionControl(), this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters,
+    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new CvsSubmitEditor(&submitParameters); }));
+        []() { return new CvsSubmitEditor(&submitParameters); }, this);
 
     const auto describeFunc = [this](const QString &source, const QString &changeNr) {
         QString errorMessage;
@@ -217,11 +217,10 @@ bool CvsPlugin::initialize(const QStringList &arguments, QString *errorMessage)
     const int editorCount = sizeof(editorParameters) / sizeof(editorParameters[0]);
     const auto widgetCreator = []() { return new CvsEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
     const QString prefix = QLatin1String("cvs");
-    m_commandLocator = new CommandLocator("CVS", prefix, prefix);
+    m_commandLocator = new CommandLocator("CVS", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     // Register actions
     ActionContainer *toolsContainer = ActionManager::actionContainer(M_TOOLS);

src/plugins/cvs/settingspage.cpp

@@ -72,8 +72,8 @@ void SettingsPageWidget::setSettings(const VcsBaseClientSettings &s)
     m_ui.describeByCommitIdCheckBox->setChecked(s.boolValue(CvsSettings::describeByCommitIdKey));
 }
 
-SettingsPage::SettingsPage(Core::IVersionControl *control) :
+SettingsPage::SettingsPage(Core::IVersionControl *control, QObject *parent) :
-    VcsClientOptionsPage(control, CvsPlugin::instance()->client())
+    VcsClientOptionsPage(control, CvsPlugin::instance()->client(), parent)
 {
     setId(VcsBase::Constants::VCS_ID_CVS);
     setDisplayName(tr("CVS"));

src/plugins/cvs/settingspage.h

@@ -54,7 +54,7 @@ class SettingsPage : public VcsBase::VcsClientOptionsPage
     Q_OBJECT
 
 public:
-    SettingsPage(Core::IVersionControl *control);
+    SettingsPage(Core::IVersionControl *control, QObject *parent);
 };
 
 } // namespace Cvs

src/plugins/git/gerrit/gerritplugin.cpp

@@ -293,7 +293,7 @@ bool GerritPlugin::initialize(ActionContainer *ac)
     connect(pushAction, &QAction::triggered, this, [this]() { push(); });
     ac->addAction(m_pushToGerritCommand);
 
-    GitPlugin::instance()->addAutoReleasedObject(new GerritOptionsPage(m_parameters));
+    new GerritOptionsPage(m_parameters, this);
     return true;
 }
 

src/plugins/git/gitgrep.cpp

@@ -218,7 +218,8 @@ static bool isGitDirectory(const QString &path)
     return gitVc == VcsManager::findVersionControlForDirectory(path, 0);
 }
 
-GitGrep::GitGrep()
+GitGrep::GitGrep(QObject *parent)
+    : SearchEngine(parent)
 {
     m_widget = new QWidget;
     auto layout = new QHBoxLayout(m_widget);

src/plugins/git/gitgrep.h

@@ -39,7 +39,7 @@ class GitGrep : public TextEditor::SearchEngine
     Q_DECLARE_TR_FUNCTIONS(GitGrep)
 
 public:
-    GitGrep();
+    explicit GitGrep(QObject *parent);
     ~GitGrep() override;
     QString title() const override;
     QString toolTip() const override;

src/plugins/git/gitplugin.cpp

@@ -299,12 +299,11 @@ bool GitPlugin::initialize(const QStringList &arguments, QString *errorMessage)
     auto vc = initializeVcs<GitVersionControl>(context, m_gitClient);
 
     // Create the settings Page
-    auto settingsPage = new SettingsPage(vc);
+    auto settingsPage = new SettingsPage(vc, this);
-    addAutoReleasedObject(settingsPage);
     connect(settingsPage, &SettingsPage::settingsChanged,
             this, &GitPlugin::updateRepositoryBrowserAction);
 
-    addAutoReleasedObject(new GitGrep);
+    new GitGrep(this);
 
     const auto describeFunc = [this](const QString &source, const QString &id) {
         m_gitClient->show(source, id);
@@ -312,14 +311,13 @@ bool GitPlugin::initialize(const QStringList &arguments, QString *errorMessage)
     const int editorCount = sizeof(editorParameters) / sizeof(editorParameters[0]);
     const auto widgetCreator = []() { return new GitEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters,
+    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new GitSubmitEditor(&submitParameters); }));
+        []() { return new GitSubmitEditor(&submitParameters); }, this);
 
     const QString prefix = "git";
-    m_commandLocator = new CommandLocator("Git", prefix, prefix);
+    m_commandLocator = new CommandLocator("Git", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     //register actions
     ActionContainer *toolsContainer = ActionManager::actionContainer(Core::Constants::M_TOOLS);

src/plugins/git/settingspage.cpp

@@ -106,8 +106,8 @@ void SettingsPageWidget::updateNoteField()
 }
 
 // -------- SettingsPage
-SettingsPage::SettingsPage(Core::IVersionControl *control) :
+SettingsPage::SettingsPage(Core::IVersionControl *control, QObject *parent) :
-    VcsClientOptionsPage(control, GitPlugin::client())
+    VcsClientOptionsPage(control, GitPlugin::client(), parent)
 {
     setId(VcsBase::Constants::VCS_ID_GIT);
     setDisplayName(tr("Git"));

src/plugins/git/settingspage.h

@@ -59,7 +59,7 @@ class SettingsPage : public VcsBase::VcsClientOptionsPage
     Q_OBJECT
 
 public:
-    SettingsPage(Core::IVersionControl *control);
+    SettingsPage(Core::IVersionControl *control, QObject *parent);
     void apply() override;
 };
 

src/plugins/mercurial/mercurialplugin.cpp

@@ -124,7 +124,7 @@ bool MercurialPlugin::initialize(const QStringList & /* arguments */, QString *
     m_client = new MercurialClient;
     auto vc = initializeVcs<MercurialControl>(context, m_client);
 
-    addAutoReleasedObject(new OptionsPage(vc));
+    new OptionsPage(vc, this);
 
     connect(m_client, &VcsBaseClient::changed, vc, &MercurialControl::changed);
     connect(m_client, &MercurialClient::needUpdate, this, &MercurialPlugin::update);
@@ -135,14 +135,13 @@ bool MercurialPlugin::initialize(const QStringList & /* arguments */, QString *
     const int editorCount = sizeof(editorParameters)/sizeof(editorParameters[0]);
     const auto widgetCreator = []() { return new MercurialEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitEditorParameters,
+    new VcsSubmitEditorFactory(&submitEditorParameters,
-        []() { return new CommitEditor(&submitEditorParameters); }));
+        []() { return new CommitEditor(&submitEditorParameters); }, this);
 
     const QString prefix = QLatin1String("hg");
-    m_commandLocator = new Core::CommandLocator("Mercurial", prefix, prefix);
+    m_commandLocator = new Core::CommandLocator("Mercurial", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     createMenu(context);
 

src/plugins/mercurial/optionspage.cpp

@@ -68,8 +68,8 @@ void OptionsPageWidget::setSettings(const VcsBaseClientSettings &s)
     m_ui.timeout->setValue(s.intValue(MercurialSettings::timeoutKey));
 }
 
-OptionsPage::OptionsPage(Core::IVersionControl *control) :
+OptionsPage::OptionsPage(Core::IVersionControl *control, QObject *parent) :
-    VcsClientOptionsPage(control, MercurialPlugin::client())
+    VcsClientOptionsPage(control, MercurialPlugin::client(), parent)
 {
     setId(VcsBase::Constants::VCS_ID_MERCURIAL);
     setDisplayName(tr("Mercurial"));

src/plugins/mercurial/optionspage.h

@@ -53,7 +53,7 @@ class OptionsPage : public VcsBase::VcsClientOptionsPage
     Q_OBJECT
 
 public:
-    OptionsPage(Core::IVersionControl *control);
+    OptionsPage(Core::IVersionControl *control, QObject *parent);
 };
 
 } // namespace Internal

src/plugins/perforce/perforceplugin.cpp

@@ -189,11 +189,11 @@ bool PerforcePlugin::initialize(const QStringList & /* arguments */, QString *er
 
     m_settings.fromSettings(ICore::settings());
 
-    addAutoReleasedObject(new SettingsPage);
+    new SettingsPage(this);
 
     // Editor factories
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters,
+    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new PerforceSubmitEditor(&submitParameters); }));
+        []() { return new PerforceSubmitEditor(&submitParameters); }, this);
 
     const auto describeFunc = [this](const QString &source, const QString &n) {
         describe(source, n);
@@ -201,11 +201,10 @@ bool PerforcePlugin::initialize(const QStringList & /* arguments */, QString *er
     const int editorCount = sizeof(editorParameters) / sizeof(editorParameters[0]);
     const auto widgetCreator = []() { return new PerforceEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
     const QString prefix = QLatin1String("p4");
-    m_commandLocator = new CommandLocator("Perforce", prefix, prefix);
+    m_commandLocator = new CommandLocator("Perforce", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     ActionContainer *mtools = ActionManager::actionContainer(Core::Constants::M_TOOLS);
 

src/plugins/perforce/settingspage.cpp

@@ -117,7 +117,8 @@ void SettingsPageWidget::setStatusError(const QString &t)
     m_ui.errorLabel->setText(t);
 }
 
-SettingsPage::SettingsPage()
+SettingsPage::SettingsPage(QObject *parent)
+    : VcsBaseOptionsPage(parent)
 {
     setId(VcsBase::Constants::VCS_ID_PERFORCE);
     setDisplayName(tr("Perforce"));

src/plugins/perforce/settingspage.h

@@ -64,7 +64,7 @@ class SettingsPage : public VcsBase::VcsBaseOptionsPage
     Q_OBJECT
 
 public:
-    SettingsPage();
+    explicit SettingsPage(QObject *parent);
     ~SettingsPage() override;
 
     QWidget *widget() override;

src/plugins/silversearcher/findinfilessilversearcher.cpp

@@ -132,8 +132,9 @@ void runSilverSeacher(FutureInterfaceType &fi, FileFindParameters parameters)
 
 namespace SilverSearcher {
 
-FindInFilesSilverSearcher::FindInFilesSilverSearcher()
+FindInFilesSilverSearcher::FindInFilesSilverSearcher(QObject *parent)
-    : m_widget(0),
+    : SearchEngine(parent),
+      m_widget(0),
       m_path("ag"),
       m_toolName("SilverSearcher")
 {

src/plugins/silversearcher/findinfilessilversearcher.h

@@ -39,7 +39,7 @@ class FindInFilesSilverSearcher : public TextEditor::SearchEngine
     Q_OBJECT
 
 public:
-    FindInFilesSilverSearcher();
+    explicit FindInFilesSilverSearcher(QObject *parent);
     ~FindInFilesSilverSearcher() override;
 
     // TextEditor::FileFindExtension

src/plugins/silversearcher/silversearcherplugin.cpp

@@ -35,7 +35,7 @@ bool SilverSearcherPlugin::initialize(const QStringList &arguments, QString *err
     Q_UNUSED(arguments)
     Q_UNUSED(errorString)
 
-    addAutoReleasedObject(new FindInFilesSilverSearcher);
+    new FindInFilesSilverSearcher(this);
 
     return true;
 }

src/plugins/subversion/settingspage.cpp

@@ -80,8 +80,8 @@ void SettingsPageWidget::setSettings(const VcsBaseClientSettings &s)
     m_ui.logCountSpinBox->setValue(s.intValue(SubversionSettings::logCountKey));
 }
 
-SettingsPage::SettingsPage(Core::IVersionControl *control) :
+SettingsPage::SettingsPage(Core::IVersionControl *control, QObject *parent) :
-    VcsClientOptionsPage(control, SubversionPlugin::instance()->client())
+    VcsClientOptionsPage(control, SubversionPlugin::instance()->client(), parent)
 {
     setId(VcsBase::Constants::VCS_ID_SUBVERSION);
     setDisplayName(tr("Subversion"));

src/plugins/subversion/settingspage.h

@@ -56,7 +56,7 @@ class SettingsPage : public VcsBase::VcsClientOptionsPage
     Q_OBJECT
 
 public:
-    SettingsPage(Core::IVersionControl *control);
+    SettingsPage(Core::IVersionControl *control, QObject *parent);
 };
 
 } // namespace Subversion

src/plugins/subversion/subversionplugin.cpp

@@ -216,10 +216,10 @@ bool SubversionPlugin::initialize(const QStringList & /*arguments */, QString *e
 
     m_client = new SubversionClient;
 
-    addAutoReleasedObject(new SettingsPage(versionControl()));
+    new SettingsPage(versionControl(), this);
 
-    addAutoReleasedObject(new VcsSubmitEditorFactory(&submitParameters,
+    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new SubversionSubmitEditor(&submitParameters); }));
+        []() { return new SubversionSubmitEditor(&submitParameters); }, this);
 
     const auto describeFunc = [this](const QString &source, const QString &id) {
         describe(source, id);
@@ -227,11 +227,10 @@ bool SubversionPlugin::initialize(const QStringList & /*arguments */, QString *e
     const int editorCount = sizeof(editorParameters) / sizeof(editorParameters[0]);
     const auto widgetCreator = []() { return new SubversionEditorWidget; };
     for (int i = 0; i < editorCount; i++)
-        addAutoReleasedObject(new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc));
+        new VcsEditorFactory(editorParameters + i, widgetCreator, describeFunc, this);
 
     const QString prefix = QLatin1String("svn");
-    m_commandLocator = new CommandLocator("Subversion", prefix, prefix);
+    m_commandLocator = new CommandLocator("Subversion", prefix, prefix, this);
-    addAutoReleasedObject(m_commandLocator);
 
     // Register actions
     ActionContainer *toolsContainer = ActionManager::actionContainer(M_TOOLS);

src/plugins/texteditor/basefilefind.cpp

@@ -157,8 +157,8 @@ static void updateComboEntries(QComboBox *combo, bool onTop)
 
 using namespace Internal;
 
-SearchEngine::SearchEngine()
+SearchEngine::SearchEngine(QObject *parent)
-    : d(new SearchEnginePrivate)
+    : QObject(parent), d(new SearchEnginePrivate)
 {
 }
 

src/plugins/texteditor/basefilefind.h

@@ -65,7 +65,7 @@ class TEXTEDITOR_EXPORT SearchEngine : public QObject
 {
     Q_OBJECT
 public:
-    SearchEngine();
+    SearchEngine(QObject *parent = nullptr);
     ~SearchEngine();
     virtual QString title() const = 0;
     virtual QString toolTip() const = 0; // add %1 placeholder where the find flags should be put

src/plugins/vcsbase/basevcseditorfactory.cpp

@@ -52,7 +52,8 @@ namespace VcsBase {
 VcsEditorFactory::VcsEditorFactory(const VcsBaseEditorParameters *parameters,
                                    // Force copy, see QTCREATORBUG-13218
                                    const EditorWidgetCreator editorWidgetCreator,
-                                   std::function<void(const QString &, const QString &)> describeFunc)
+                                   std::function<void(const QString &, const QString &)> describeFunc, QObject *parent)
+    : TextEditorFactory(parent)
 {
     setProperty("VcsEditorFactoryName", QByteArray(parameters->id));
     setId(parameters->id);

src/plugins/vcsbase/basevcseditorfactory.h

@@ -42,7 +42,8 @@ class VCSBASE_EXPORT VcsEditorFactory : public TextEditor::TextEditorFactory
 public:
     VcsEditorFactory(const VcsBaseEditorParameters *parameters,
                      const EditorWidgetCreator editorWidgetCreator,
-                     std::function<void(const QString &, const QString &)> describeFunc);
+                     std::function<void(const QString &, const QString &)> describeFunc,
+                     QObject *parent = nullptr);
 
     static VcsBaseEditor *createEditorById(const char *id);
 };

src/plugins/vcsbase/basevcssubmiteditorfactory.cpp

@@ -29,8 +29,10 @@
 namespace VcsBase {
 
 VcsSubmitEditorFactory::VcsSubmitEditorFactory
-        (const VcsBaseSubmitEditorParameters *parameters, const EditorCreator &editorCreator)
+        (const VcsBaseSubmitEditorParameters *parameters,
-    : m_editorCreator(editorCreator)
+         const EditorCreator &editorCreator,
+         QObject *parent)
+    : IEditorFactory(parent), m_editorCreator(editorCreator)
 {
     setId(parameters->id);
     setDisplayName(QLatin1String(parameters->displayName));

src/plugins/vcsbase/basevcssubmiteditorfactory.h

@@ -44,7 +44,9 @@ class VCSBASE_EXPORT VcsSubmitEditorFactory : public Core::IEditorFactory
 public:
     typedef std::function<VcsBaseSubmitEditor *()> EditorCreator;
 
-    VcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters *parameters, const EditorCreator &editorCreator);
+    VcsSubmitEditorFactory(const VcsBaseSubmitEditorParameters *parameters,
+                           const EditorCreator &editorCreator,
+                           QObject *parent = nullptr);
 
     Core::IEditor *createEditor() override;
 

src/plugins/vcsbase/vcsplugin.cpp

@@ -85,7 +85,6 @@ bool VcsPlugin::initialize(const QStringList &arguments, QString *errorMessage)
     });
 
     m_settingsPage = new CommonOptionsPage;
-    addAutoReleasedObject(m_settingsPage);
     addAutoReleasedObject(VcsOutputWindow::instance());
     connect(m_settingsPage, &CommonOptionsPage::settingsChanged,
             this, &VcsPlugin::settingsChanged);