ProjectExplorer: More private and final for AppOutputPane

Q_OBJECT is also not needed.

Change-Id: Ic79232b5097b6619ecc356b02f31671120596103
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

src/plugins/projectexplorer/appoutputpane.h

@@ -24,17 +24,14 @@ namespace Core { class OutputWindow; }
 namespace ProjectExplorer {
 
 class RunControl;
-class Project;
 
 namespace Internal {
 
 class ShowOutputTaskHandler;
 class TabWidget;
 
-class AppOutputPane : public Core::IOutputPane
+class AppOutputPane final : public Core::IOutputPane
 {
-    Q_OBJECT
-
 public:
     enum CloseTabMode {
         CloseTabNoPrompt,
@@ -42,31 +39,13 @@ public:
     };
 
     AppOutputPane();
-    ~AppOutputPane() override;
+    ~AppOutputPane() final;
-
-    QWidget *outputWidget(QWidget *) override;
-    QList<QWidget *> toolBarWidgets() const override;
-    void clearContents() override;
-    bool canFocus() const override;
-    bool hasFocus() const override;
-    void setFocus() override;
-
-    bool canNext() const override;
-    bool canPrevious() const override;
-    void goToNext() override;
-    void goToPrev() override;
-    bool canNavigate() const override;
-
-    bool hasFilterContext() const override;
-
-    void showTabFor(RunControl *rc);
 
     bool aboutToClose() const;
     void closeTabs(CloseTabMode mode);
 
     QList<RunControl *> allRunControls() const;
 
-    // ApplicationOutput specifics
     const AppOutputSettings &settings() const { return m_settings; }
     void setSettings(const AppOutputSettings &settings);
 
@@ -74,6 +53,8 @@ public:
     void showOutputPaneForRunControl(RunControl *runControl);
 
 private:
+    void showTabFor(RunControl *rc);
+
     void setBehaviorOnOutput(RunControl *rc, AppOutputPaneMode mode);
     void projectRemoved();
 
@@ -117,9 +98,25 @@ private:
     RunControl *currentRunControl() const;
     void handleOldOutput(Core::OutputWindow *window) const;
     void updateCloseActions();
-    void updateFilter() override;
+
-    const QList<Core::OutputWindow *> outputWindows() const override;
+    QWidget *outputWidget(QWidget *) final;
-    void ensureWindowVisible(Core::OutputWindow *ow) override;
+    QList<QWidget *> toolBarWidgets() const final;
+    void clearContents() final;
+    bool canFocus() const final;
+    bool hasFocus() const final;
+    void setFocus() final;
+
+    bool canNext() const final;
+    bool canPrevious() const final;
+    void goToNext() final;
+    void goToPrev() final;
+    bool canNavigate() const final;
+
+    bool hasFilterContext() const final;
+
+    void updateFilter() final;
+    const QList<Core::OutputWindow *> outputWindows() const final;
+    void ensureWindowVisible(Core::OutputWindow *ow) final;
 
     void loadSettings();
     void storeSettings() const;