feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: remove one of the three failure notification if a gdb binary is

Browse Source 
not found with the remote adapter
This commit is contained in:
hjk
2010-09-06 14:26:19 +02:00
parent 3d78066c2c
commit 715e72117d
3 changed files with 38 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -4015,8 +4015,7 @@ bool GdbEngine::startGdb(const QStringList &args, const QString &gdb, const QStr
gdbProc()->start(m_gdb, gdbArgs);
if (!gdbProc()->waitForStarted()) {
const QString msg = tr("Unable to start gdb '%1': %2")
.arg(m_gdb, gdbProc()->errorString());
const QString msg = errorMessage(QProcess::FailedToStart);
handleAdapterStartFailed(msg, settingsIdHint);
return false;
}
@@ -4129,19 +4128,23 @@ bool GdbEngine::checkDebuggingHelpers()
void GdbEngine::handleGdbError(QProcess::ProcessError error)
{
showMessage(_("HANDLE GDB ERROR: ") + errorMessage(error));
const QString msg = errorMessage(error);
showMessage(_("HANDLE GDB ERROR: ") + msg);
// Show a message box for asynchroneously reported issues.
switch (error) {
case QProcess::FailedToStart:
// This should be handled by the code trying to start the process.
break;
case QProcess::Crashed:
break; // will get a processExited() as well
// impossible case QProcess::FailedToStart:
// This will get a processExited() as well.
break;
case QProcess::ReadError:
case QProcess::WriteError:
case QProcess::Timedout:
default:
//gdbProc()->kill();
//setState(EngineShutdownRequested, true);
showMessageBox(QMessageBox::Critical, tr("Gdb I/O Error"),
errorMessage(error));
showMessageBox(QMessageBox::Critical, tr("Gdb I/O Error"), msg);
break;
}
}